Last modified: 2013-08-27 05:08:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49750, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 47750 - Jenkins: should run tests/AutoLoaderTest.php


Summary:	Jenkins: should run tests/AutoLoaderTest.php

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Antoine "hashar" Musso (WMF)

URL:
Whiteboard:
Keywords:	patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-04-26 20:04 UTC by Adam Wight
Modified:	2013-08-27 05:08 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Adam Wight 2013-04-26 20:04:08 UTC

I suspect that CI is not running this test, because it has been failing on master for a while.  I had to make these changes to successfully run the tests:
https://gerrit.wikimedia.org/r/#/c/59804/9/tests/TestsAutoLoader.php

Comment 1 Antoine "hashar" Musso (WMF) 2013-05-21 09:33:31 UTC

The AutoLoaderTest.php is not registered in phpunit. I have created https://gerrit.wikimedia.org/r/#/c/64788/ which registered it in suite.xml under the 'structure' test suite and that fails accordingly.

Comment 2 Antoine "hashar" Musso (WMF) 2013-05-21 09:54:09 UTC

I have added the missing autoloader entries.

Comment 3 Gerrit Notification Bot 2013-05-21 09:59:52 UTC

Related URL: https://gerrit.wikimedia.org/r/64791 (Gerrit Change I285fa7ed24a6fc45a4dc475b54d80cf3816436fb)

Comment 4 Antoine "hashar" Musso (WMF) 2013-05-21 10:40:54 UTC

https://gerrit.wikimedia.org/r/#/c/64791/ fix the missing AutoLoader entries

https://gerrit.wikimedia.org/r/#/c/64788/ move the AutoLoaderTest.php StructureTest.php files under /tests/phpunit/structures and register that directory in PHPUnit suite.

Both changes fix the issue. The later probably need a backport in release branches with their own autoloading fixes.

Comment 5 Krinkle 2013-06-03 20:17:14 UTC

Can this issue be closed?

Comment 6 Antoine "hashar" Musso (WMF) 2013-06-06 08:53:49 UTC

We should test it out one last time to make sure it is working properly.

Ideally I would want that to be backported in the release branches as well, though we usually do not introduce new classes in release branches post release.

Comment 7 Gerrit Notification Bot 2013-08-26 11:47:06 UTC

Change 80981 had a related patch set uploaded by Hashar:
test: run autoloader suite

https://gerrit.wikimedia.org/r/80981

Comment 8 Antoine "hashar" Musso (WMF) 2013-08-26 11:51:38 UTC

REL1_19 and REL1_20 do not have an autoloading test.  Change 80981 tweak REL1_21.

Comment 9 Gerrit Notification Bot 2013-08-27 02:24:38 UTC

Change 80981 merged by jenkins-bot:
test: run autoloader suite

https://gerrit.wikimedia.org/r/80981

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links