Last modified: 2013-05-02 03:38:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49753, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47753 - Adapt "contributors" benefit for different values of $wgActiveUserDays
Adapt "contributors" benefit for different values of $wgActiveUserDays
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-26 21:33 UTC by Matthew Flaschen
Modified: 2013-05-02 03:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-04-26 21:33:46 UTC
The default and recommended value of $wgActiveUserDays is 30.  However, if this is different, the third benefit should adapt accordingly.  

The magic word NUMBEROFACTIVEUSERS is used in MediaWiki:createacct-benefit-head3.    The current text of the corresponding MediaWiki:createacct-benefit-body3 is "contributors this month".  This is the part that should output correct text regardless of $wgActiveUserDays.  We prefer to keep "this month" if it *is* the default 30-day value.
Comment 1 db [inactive,noenotif] 2013-04-26 23:12:30 UTC
By the way, "this month" refer to the current month or to the last 30/31 days? For me, it means from the first of the current month until now, so that is already misleading/unclear. Having the days there makes things clearer.
Comment 2 Matthew Flaschen 2013-04-26 23:29:25 UTC
"last 30/31 days".

If you can think of a concise phrase that's clearer than "this month", we'll consider it.
Comment 3 spage 2013-04-27 02:40:48 UTC
*IF*
              28,983
  contributors in the last 30 days

is the right thing to display by default, we can do so and dynamically adjust for the wiki's $wgActiveUserDays.  It is more accurate and clearer, but I imagine this phrase gets even wordier in other languages.
Comment 4 Gerrit Notification Bot 2013-04-27 02:41:02 UTC
Related URL: https://gerrit.wikimedia.org/r/61165 (Gerrit Change I526bfbb99c45f15dc78396da9a488a09bbf09baa)
Comment 5 Matthew Flaschen 2013-04-27 03:16:36 UTC
Hmm.  The other two benefits are one word in English, and this is five.  It's also a little more clinical.

I would prefer we use something shorter for the 30-day case, either "contributors this month" (a little vague, but I don't know if it's a real problem) or "contributors in the last month" (only a little shorter than the 30 day version).
Comment 6 MZMcBride 2013-04-27 23:54:06 UTC
Why not "recent contributors"? Is the timeframe important? :-)
Comment 7 Matthew Flaschen 2013-04-28 00:08:02 UTC
"Recent contributors" is worth considering.
Comment 8 Steven Walling 2013-04-28 01:19:08 UTC
(In reply to comment #7)
> "Recent contributors" is worth considering.

+1. I think that's better. Let's do it.
Comment 9 Gerrit Notification Bot 2013-04-28 01:43:11 UTC
Related URL: https://gerrit.wikimedia.org/r/61246 (Gerrit Change Ic3a9bf025cca338218a7dde2fe02d0409d3db2d5)
Comment 10 Matthew Flaschen 2013-04-28 01:46:00 UTC
That proposed change is for all cases, including the 30-day case.  Steven, correct me if that's not what you meant.
Comment 11 Matthew Flaschen 2013-05-02 03:38:00 UTC
The "recent contributors" change was merged.  Since that isn't a specific timeframe, no further adaptation is necessary.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links