Last modified: 2013-04-30 04:49:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49849, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47849 - v1.9a SMW_conceptCache.php Fatal error on master
v1.9a SMW_conceptCache.php Fatal error on master
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-29 22:11 UTC by Jamie Thingelstad
Modified: 2013-04-30 04:49 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jamie Thingelstad 2013-04-29 22:11:26 UTC
I'm on the master branch of SMW 1.9a (http://wikiapiary.com/wiki/Special:Version) and trying to execute SMW_conceptCache.php throws a fatal error if any concepts are defined.

php SMW_conceptCache.php --create --update --old 60

PHP Fatal error:  Cannot use object of type SMW\DIConcept as array in .../extensions/SemanticMediaWiki/maintenance/SMW_conceptCache.php on line 147
Comment 1 Gerrit Notification Bot 2013-04-29 22:58:41 UTC
Related URL: https://gerrit.wikimedia.org/r/61507 (Gerrit Change I846682b975c8eb4f9d0b09c827d34a8cf130f54a)
Comment 2 MWJames 2013-04-29 23:05:07 UTC
Thanks for reporting, if possible please confirm if the patch solves the reported issue before merging with the master.
Comment 3 Jamie Thingelstad 2013-04-30 01:30:14 UTC
(Just an FYI, this is my first time using concept caching in SMW so I'm really only looking at the output of SMW_conceptCache.php and not inside of SMW itself.)

I applied the patch:

% git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/SemanticMediaWiki refs/changes/07/61507/1 && git format-patch -1 --stdout FETCH_HEAD | patch -p1
From https://gerrit.wikimedia.org/r/mediawiki/extensions/SemanticMediaWiki
 * branch            refs/changes/07/61507/1 -> FETCH_HEAD
patching file includes/storage/SQLStore/SMW_SQLStore3_Queries.php
patching file maintenance/SMW_conceptCache.php

and it looks like it's working great now!

SMW Concept caching for wikiapiary.com...
Mon Apr 29 20:28:17 CDT 2013

Displaying concept cache status information. Use CTRL-C to abort.

(0) Status of cache for "Concept:Websites to share": Not cached.
(1) Status of cache for "Concept:Extensions to share": Not cached.
(2) Status of cache for "Concept:Farms to share": Not cached.
(3) Status of cache for "Concept:Websites never audited": Not cached.
(4) Status of cache for "Concept:Websites expired audit": Not cached.


Done.

Creating/updating concept caches. Use CTRL-C to abort.

(0) Creating cache for "Concept:Websites to share" ...
(1) Creating cache for "Concept:Extensions to share" ...
(2) Creating cache for "Concept:Farms to share" ...
(3) Creating cache for "Concept:Websites never audited" ...
(4) Creating cache for "Concept:Websites expired audit" ...


Done.

Displaying concept cache status information. Use CTRL-C to abort.

(0) Status of cache for "Concept:Websites to share": Cache created at 2013-04-30 01:28:35 (0 minutes old), 4755 elements in cache
(1) Status of cache for "Concept:Extensions to share": Cache created at 2013-04-30 01:28:35 (0 minutes old), 1189 elements in cache
(2) Status of cache for "Concept:Farms to share": Cache created at 2013-04-30 01:28:35 (0 minutes old), 53 elements in cache
(3) Status of cache for "Concept:Websites never audited": Cache created at 2013-04-30 01:28:40 (0 minutes old), 0 elements in cache
(4) Status of cache for "Concept:Websites expired audit": Cache created at 2013-04-30 01:28:40 (0 minutes old), 0 elements in cache


Done.
Comment 4 Gerrit Notification Bot 2013-04-30 04:47:19 UTC
https://gerrit.wikimedia.org/r/61507 (Gerrit Change I846682b975c8eb4f9d0b09c827d34a8cf130f54a) | change APPROVED and MERGED [by jenkins-bot]
Comment 5 MWJames 2013-04-30 04:49:47 UTC
Thanks, the information was utterly sufficient.

The issue was a result of [1] and while I'm at it I fixed a "real" bug where $this->compileQueries( $desc ) would return -1
and break with $this->executeQueries( $this->m_queries[$qid] ) due to a problem when trying to access an array with index -1.

[1] https://gerrit.wikimedia.org/r/#/c/44609/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links