Last modified: 2013-05-14 12:33:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49944, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47944 - $wgLogTypes contains "suppress" twice on enwiki
$wgLogTypes contains "suppress" twice on enwiki
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-01 17:08 UTC by Svick
Modified: 2013-05-14 12:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Svick 2013-05-01 17:08:32 UTC
When looking at possible values of the logtype property of the watchlist API module on enwiki [1], the value "suppress" is included twice.

This list comes from the variable $wgLogTypes. The first "suppress" is default, the second seems to be added by ArticleFeedbackv5 [2].

I think $wgLogTypes should not contain duplicate values, so ArticleFeedbackv5 shouldn't be adding it.

[1]: http://en.wikipedia.org/w/api.php?format=xml&action=paraminfo&querymodules=watchlist
[2]: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ArticleFeedbackv5.git;a=blob;f=ArticleFeedbackv5.php;h=79a87377bce0b98eb868c93d5dfc288f2b25d08f;hb=HEAD#l458
Comment 1 Sam Reed (reedy) 2013-05-01 17:15:12 UTC
reedy@fenari:~$ mwscript eval.php enwiki
> var_dump( $wgLogTypes );
array(29) {
  [0]=>
  string(0) ""
  [1]=>
  string(5) "block"
  [2]=>
  string(7) "protect"
  [3]=>
  string(6) "rights"
  [4]=>
  string(6) "delete"
  [5]=>
  string(6) "upload"
  [6]=>
  string(4) "move"
  [7]=>
  string(6) "import"
  [8]=>
  string(6) "patrol"
  [9]=>
  string(5) "merge"
  [10]=>
  string(8) "suppress"
  [11]=>
  string(6) "review"
  [12]=>
  string(6) "stable"
  [13]=>
  string(8) "gblblock"
  [14]=>
  string(10) "renameuser"
  [15]=>
  string(10) "globalauth"
  [16]=>
  string(9) "gblrights"
  [17]=>
  string(11) "abusefilter"
  [18]=>
  string(17) "articlefeedbackv5"
  [19]=>
  string(8) "suppress"
  [20]=>
  string(19) "pagetriage-curation"
  [21]=>
  string(19) "pagetriage-deletion"
  [22]=>
  string(11) "institution"
  [23]=>
  string(6) "course"
  [24]=>
  string(7) "student"
  [25]=>
  string(6) "online"
  [26]=>
  string(6) "campus"
  [27]=>
  string(10) "instructor"
  [28]=>
  string(8) "newusers"
}
Comment 2 Gerrit Notification Bot 2013-05-01 17:20:06 UTC
Related URL: https://gerrit.wikimedia.org/r/61795 (Gerrit Change I850f0f179b2b681ed50655b5b1b545fb311ee25e)
Comment 3 Gerrit Notification Bot 2013-05-01 17:35:44 UTC
Related URL: https://gerrit.wikimedia.org/r/61798 (Gerrit Change I956b69762ad5888f26fb3202d372f34cdb7ed7ef)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links