Last modified: 2013-05-02 01:34:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49959, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47959 - Set $wgDebugRawPage = true; for all wikis
Set $wgDebugRawPage = true; for all wikis
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
wmf-deployment
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-02 00:56 UTC by Krinkle
Modified: 2013-05-02 01:34 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-05-02 00:56:21 UTC
If agreed upon, perhaps also set it to true by default or even delete the variable in mediawiki/core in general.

ResourceLoader emits certain errors (wfDebugLog('resourceloader', ..)) which cannot be found any other way. Quite major and critical errors.

But they are being excluded from the debug.log etc. because they occur from a load.php request and since wfIsDebugRawPage() returns true for load.php and wgDebugRawPage being false, we never see them.

wgDebugRawPage was originally introduced to "to avoid overlapping debug entries" because action=raw pages were very simplistic. Any error happening there is either extremely rare or something also happening on the index.php request that referenced action=raw.

However this is not true for load.php. That should never have been suppressed[1] in my opinion.

A common error is a mistake in the module definition (e.g. referencing a javascript file that doesn't exist, minification failing, dependency problems etc.) that should be logged. At least on wmf.


[1] https://github.com/wikimedia/mediawiki-core/commit/c00d63dda3df84fd728dc21ffe8bab8060d76ebc
Comment 1 Krinkle 2013-05-02 01:34:45 UTC
Combination of bug 44018 and bug 47960 is good enough for me.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links