Last modified: 2013-07-04 10:33:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49998, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47998 - Selser corruption?
Selser corruption?
Status: RESOLVED WORKSFORME
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on: 48006
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-02 14:28 UTC by C. Scott Ananian
Modified: 2013-07-04 10:33 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description C. Scott Ananian 2013-05-02 14:28:29 UTC
https://pl.wikipedia.org/w/index.php?title=Squat&curid=6048&diff=36327967&oldid=36176788 was VE edit.

It looks like some parts were swapped with some other parts in german (and this is the polish wikipedia).

The user says this wasn't visible in the "Review and save" diff.

(reported by MatmaRex in #mediawiki-parsoid.)
Comment 1 C. Scott Ananian 2013-05-02 14:29:14 UTC
Looks like a selser problem to me; the corrupted regions correspond to <a> and <b> tags in the HTML DOM.
Comment 2 ssastry 2013-05-02 14:53:12 UTC
Interesting.  So, I suppose the wikitext source fetched for this page came from the German wikipedia rather than Polish wikipedia.  I wonder if the wiki prefix was incorrect, or if Parsoid used this from a cache and the cache-key didn't include the wiki prefix.

The polish wikipedia wikitext is: https://pl.wikipedia.org/w/index.php?title=Benutzer_Diskussion:EvaK&action=edit&oldid=36176788

The german wikipedia wikitext is:
https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:EvaK&action=edit&oldid=36176788

From the pl page diff, it is clear that the incorrect text came from the german wikitext above.

So, I suspect either a caching bug or incorrect params received from VE.
Comment 3 Gabriel Wicke 2013-05-02 14:56:34 UTC
Note that the issue was reported to not have shown in the diff.
Comment 4 ssastry 2013-05-02 15:16:24 UTC
Sorry, the correct polish wikipedia wikitext is:
https://pl.wikipedia.org/w/index.php?action=edit&oldid=36176788
Comment 5 Gabriel Wicke 2013-05-02 15:26:42 UTC
I think we are all assuming that this actually showed up in the diff as otherwise the corruption would have happened while the VE sent *wikitext* to the API to save it, without any Parsoid involvement.
Comment 6 Gabriel Wicke 2013-05-02 15:44:15 UTC
I have traced the code from the POST end point to the TemplateRequest for selser, and did not find any issues. The language is determined by making the API request to the right wiki's apiURI which is set in env.conf.parsoid, and afaik never written to.

If there was a bug in this area we would see a lot of issues, not just one.

So my guess is that we got an incorrect prefix passed in.
Comment 7 Gabriel Wicke 2013-05-02 15:50:32 UTC
The VE API module uses $wgVisualEditorParsoidPrefix to construct the prefix, which is likely correct for pl as the GET uses it too and succeeded. An incorrect prefix could be passed in if VE posted to the de.wikipedia.org API instead of the pl.wikipedia.org one. This is determined by host header, so DNS would not be the issue. The incorrect URL would need to be constructed client-side.
Comment 8 Gabriel Wicke 2013-05-02 15:55:10 UTC
Reported for VE in bug 48006.
Comment 9 Gabriel Wicke 2013-05-07 16:29:54 UTC
Lowering priority for now as the report seems to be less than reliable and we have not been able to reproduce this.
Comment 10 Gabriel Wicke 2013-05-10 20:03:30 UTC
Closing for now, please reopen if this happens again.
Comment 11 Andre Klapper 2013-07-04 10:33:57 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links