Last modified: 2013-06-20 19:51:38 UTC
could we make the puppet syntax check / operations-puppet-pep8 in jenkins ignore this error: "W191 indentation contains tabs" but still show all the others? reasoning: We will likely never agree on a indentation style. While it/puppet-lint expect 2-space soft tabs we are largely still using actual tabs. This way we kill a huge percentage of errors at once and seeing the other, possibly more important, errors would be much easier. recently the stats were: "We get 35344 warnings or errors on 27982 lines of code"
By far the most common error is: "tab character found on line" with 20362.
Technically pep8 let you ignore specific errors and warnings using the 'ignore' parameter. That can be put in a .pep8 file at the root of the repository, something like: [pep8] # Ignore W191 indentation contains tabs ignore = W191 If that is done, that means python files hosted in the repository could use either spaces or tabs. The files using tabs should probably be tagged properly for the editors to use the "proper" spacing. Aka for vim a modeline such as: vim: set noet: <bikeshed>For consistency, I would advise sticking to the pep8 standard :)</bikeshed>
Andrew Bogott wrote a bunch of changes in operations/puppet.git that makes its pass pep8. An important change is https://gerrit.wikimedia.org/r/#/c/66552/ (in integration/jenkins.git) which let us sneak pep8 configuration files in sub directories and thus finely tune pep8 behavior. Anyway, fixed :-)
