Last modified: 2013-05-13 17:17:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50069, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48069 - VisualEditor: Indenting multiple list items now broken in Firefox
VisualEditor: Indenting multiple list items now broken in Firefox
Status: RESOLVED DUPLICATE of bug 48390
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Highest normal
: VE-deploy-2013-05-27
Assigned To: Inez Korczyński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-04 06:56 UTC by Moriel Schottlender
Modified: 2013-05-13 17:17 UTC (History)
6 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Moriel Schottlender 2013-05-04 06:56:49 UTC
Multiple list items don't indent properly.

Steps to duplicate the bug:

Write a couple of lines. Mark all the lines and click the "list" button - producing bullet-list. 

If the indent button is clicked when the cursor is on a single list item, that item will be indented. However, if you mark a couple of list items and indent them at once, the indentation is jumbled: some of the items are indented and some double-indented (and the item above the selection seems to be indented as well)
Comment 1 James Forrester 2013-05-04 18:42:58 UTC
Broken in master for Firefox but not in wmf3 - presumably we changed something in the last week that did this?
Comment 2 Moriel Schottlender 2013-05-04 19:02:08 UTC
I am entirely not sure if I am in the right direction here, but I figured I'd share my intuition --

I am thinking this is some bug with the definition of child-nodes vs same-level nodes, which results in indentation as if some of the nodes selected are parents.

There was a change in ve.ce.BranchNode.js and ve.ce.ContentBranchNode.js regarding child nodes -- could this have caused it?


+ve.ce.BranchNode.prototype.onModelUpdate = function ( transaction ) {
+       this.emit( 'childUpdate', transaction );

And there are a couple of other changes in the ve.ce.BranchNode.prototype.onSplice method. Perhaps something went wrong with the definition of what is a child and what is a same-level node, which then jumbles up the hierarchy of the list?

(I do hope I am in the right direction here, I thought I'd share my thoughts)
Comment 3 Ed Sanders 2013-05-13 17:17:29 UTC

*** This bug has been marked as a duplicate of bug 48390 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links