Last modified: 2014-07-01 19:40:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50071, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48071 - action=setnotificationtimestamp throws fatal error when parameters for the page are missing
action=setnotificationtimestamp throws fatal error when parameters for the pa...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-04 07:11 UTC by Michael M.
Modified: 2014-07-01 19:40 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael M. 2013-05-04 07:11:04 UTC 
Calling action=setnotificationtimestamp with parameter newerthanrevid set to the most recent revision throws a fatal error:

PHP fatal error in /usr/local/apache/common-local/php-1.22wmf2/includes/api/ApiSetNotificationTimestamp.php line 78:
        Call to a member function getNextRevisionID() on a non-object

Expected result: The notification timestamp should be reset, as this means that the user has viewed all revisions of that page.
Comment 1 Michael M. 2013-05-04 07:25:18 UTC 
I should read the documentation first...
Repurposing this bug: When neither titles, nor pageids, nor revids, nor entierwatchlist are specified, no fatal error should be thrown, but instead a helpful error message about the fact that at least one of these parameters is required.
Comment 2 Gerrit Notification Bot 2013-05-04 12:36:22 UTC 
Related URL: https://gerrit.wikimedia.org/r/62229 (Gerrit Change I5abcdf0fa20486f1198d1cc111461b3088a311df)
Comment 3 Gerrit Notification Bot 2014-07-01 17:44:37 UTC 
Change 62229 merged by jenkins-bot:
API: Fix setnotificationtimestamp with no pages given

https://gerrit.wikimedia.org/r/62229
Comment 4 Brad Jorsch 2014-07-01 19:40:38 UTC 
Should be deployed to WMF wikis with 1.24wmf12, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links