Last modified: 2013-07-24 10:07:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50088, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48088 - Score doesn't output image size (width/height)
Score doesn't output image size (width/height)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Score (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-04 22:09 UTC by Brion Vibber
Modified: 2013-07-24 10:07 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2013-05-04 22:09:31 UTC
The Score extension outputs PNG images via <img> tags with no 'width' or 'height' attribute.

This not only forces the browser to re-flow layout once the images load, it makes it harder to replace in higher-resolution images.

Since there's no database storage where we can store images, and the handling of existing renderings works by scanning the storage directory for files, this is hard to handle in the later rendering.

One way to handle this might be to use getimagesize() on the PNGs right after they're generated, then save the filename -> size associations into a .json file and stash that in the directory along with the PNG and MIDI files.

Missing a data file could either do back-compat rendering without the width/height or could trigger a re-render, so existing renderings would be updated.
Comment 1 Gerrit Notification Bot 2013-05-04 22:55:56 UTC
Related URL: https://gerrit.wikimedia.org/r/62313 (Gerrit Change I29938c7e28a581b6b20ba683d79b33f0bbf7a3ce)
Comment 2 Gerrit Notification Bot 2013-05-05 15:31:25 UTC
https://gerrit.wikimedia.org/r/62313 (Gerrit Change I29938c7e28a581b6b20ba683d79b33f0bbf7a3ce) | change ABANDONED [by Brion VIBBER]
Comment 3 Jan Gerber 2013-07-24 10:07:01 UTC
this was fixed in I34d583c6b803e8db5eabceb07552a391eec2519c

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links