Last modified: 2013-06-29 12:46:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50115, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 48115 - Gerrit does no longer inform change reviewers via email about new patch sets


Summary:	Gerrit does no longer inform change reviewers via email about new patch sets

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Git/Gerrit (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	christian

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-05-05 23:37 UTC by christian
Modified:	2013-06-29 12:46 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description christian 2013-05-05 23:37:05 UTC

When a new patch set is added to a change in gerrit, gerrit used to
notify the change's reviewers by email.

As reported on
http://lists.wikimedia.org/pipermail/wikitech-l/2013-May/069101.html
gerrit does not send such emails any longer.

We want to have those email notifications again.

Comment 1 christian 2013-05-05 23:37:46 UTC

The problematic upstream commit seems to be
  a7c4a3a6de7353e24d7ed112f92893f3144a85af
.

Comment 2 Matthew Flaschen 2013-05-06 00:24:12 UTC

I believe Christian is referring to https://gerrit.googlesource.com/gerrit/+/a7c4a3a6de7353e24d7ed112f92893f3144a85af .

Comment 3 Gerrit Notification Bot 2013-05-06 10:46:16 UTC

Related URL: https://gerrit.wikimedia.org/r/62424 (Gerrit Change Iba1e8585054cdef3e422bd951b0c61aa824b84fc)

Comment 4 christian 2013-05-06 10:47:50 UTC

(In reply to comment #2)
> I believe Christian is referring to [...]
Ah, yes. Sorry. 


Upstream change is at
https://gerrit-review.googlesource.com/#/c/45283/

Comment 5 Matthew Flaschen 2013-06-19 08:07:29 UTC

Although 62424 is merged, this is still present.

Comment 6 christian 2013-06-19 08:29:56 UTC

When a recent upgrade of gerrit did not went too smooth, gerrit has been
rolled back. Apparently, gerrit got rolled back further than needed.
So the fix is no longer in place.

Yesterday, Chad said that he'll take a look at getting a new version
together soonish.

Comment 7 christian 2013-06-29 12:46:09 UTC

Should be fixed since we upgraded gerrit and hooks-bugzilla on 2013-06-27.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links