Last modified: 2013-07-17 14:31:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50137, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48137 - EditEntity (API) refactoring
EditEntity (API) refactoring
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-06 10:03 UTC by abraham.taherivand
Modified: 2013-07-17 14:31 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description abraham.taherivand 2013-05-06 10:03:25 UTC 

    


      




        
          Comment 1
        

        
          Daniel Kinzler

        

        
        

        
          2013-05-06 10:20:34 UTC
        
      





The EditEntity API module needs refactoring. Two steps are suggested:

1) Factor individual modifications (like set lable, remove alias) into ChangeOp classes (similar to, maybe even compatible to DiffOp). besides modifying the entity, they should faciliate the creation of summaries and permission checks.

2) Move the module's logic into a handler/controller. That controller may be aware of the API, especially of the Request and Result objects. Isolation from that knowledge would be nice, but is not essential at the moment.

    


      




        
          Comment 2
        

        
          Gerrit Notification Bot

        

        
        

        
          2013-06-03 09:50:34 UTC
        
      





Related URL: https://gerrit.wikimedia.org/r/66392 (Gerrit Change Id9146d20893f300a66b377f96bf85dc709e3d022)

    


      




        
          Comment 3
        

        
          Gerrit Notification Bot

        

        
        

        
          2013-06-04 16:52:17 UTC
        
      





Related URL: https://gerrit.wikimedia.org/r/66981 (Gerrit Change Ic27774f67f8728acbb48cbf945fda063791096cf)

    


      




        
          Comment 4
        

        
          Gerrit Notification Bot

        

        
        

        
          2013-06-13 12:41:24 UTC
        
      





Related URL: https://gerrit.wikimedia.org/r/68378 (Gerrit Change I8666bbad10595237ae89fcaf9f0f649656951037)

    


      




        
          Comment 5
        

        
          abraham.taherivand

        

        
        

        
          2013-07-17 14:31:45 UTC
        
      





Verified in Wikidata demo time July 17th

    



  






  


    

      

        

          
            

              Note
              You need to
              log in
              before you can comment on or make changes to this bug.
            

          		
        
 
      

  
        





        




  
  First
  Last
  Prev
  Next
    
  This bug is not in your last
    search results.







			

			
		
		
		
		
		
		
			

				
				
				
				
				

					
Navigation

					

						
					

				

				
				
				
				
				

					
Links