Last modified: 2014-02-12 23:53:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50153, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48153 - Section level editing surfaced on mobile sites
Section level editing surfaced on mobile sites
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-06 13:22 UTC by Jon
Modified: 2014-02-12 23:53 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2013-05-06 13:22:17 UTC
In the section headings for https://m.mediawiki.org/wiki/Watchlist_wishlist and http://en.m.wikivoyage.org/wiki/Liverpool the edit link is being printed when it shouldn't be. Previously these links were wrapped in a span with class editsection now this class has been renamed to mw-editsection (I'm not sure why it wasn't renamed to mw-edit-section or removed completely but that's another discussion)

These should be removed until a nicer  editing experience is provided.
Comment 1 Bartosz Dziewoński 2013-05-06 13:46:21 UTC
That's bug 41729 / change I6a6c12a9 and it has been preceded by a long code-review process and numerous announcements on the wikis and technical lists.

Why would you want to remove the class? It's obviously the way to style those links, and apparently it's been used by MF to hide them.
Comment 2 Jon 2013-05-06 14:57:27 UTC
I missed the numerous announcements and code review - I wasn't doubting that it happened I just found the outcome strange (albeit without knowing the history) as you can obviously style links inside headings without need of a class... but as I stated that's another discussion.

For MobileFrontend we'll just need to update the formatter to strip these as well for the time being until we have section level editing.
Comment 3 Bartosz Dziewoński 2013-05-06 17:14:29 UTC
You can have regular links in headings as well. (Does MF not support this? I'd call it a bug.)

And the section edit links are wrapped in brackets, which one would want to hide or style as well.
Comment 4 Gerrit Notification Bot 2013-05-06 17:20:39 UTC
Related URL: https://gerrit.wikimedia.org/r/62455 (Gerrit Change I46540eff3d01824cd304c10aa3806d17e1fa00d1)
Comment 5 Jon 2013-05-06 17:21:34 UTC
Well in mobile we don't need to worry about legacy support and can use css3 selectors (last-child) - in terms of [ and ] that's what ::before and ::after are for :) - another reason for making edit links part of the skin rather than in the content (see Rethinking MobileFormatter / Skins wikitech email).

Anyway https://gerrit.wikimedia.org/r/62455 fixes it for MobileFrontend
Comment 6 Bartosz Dziewoński 2013-05-06 17:41:18 UTC
You can also have headings without section edit links. So yes, the class *is* needed. And I *did* think that change through.
Comment 7 Gerrit Notification Bot 2013-05-06 17:50:56 UTC
https://gerrit.wikimedia.org/r/62455 (Gerrit Change I46540eff3d01824cd304c10aa3806d17e1fa00d1) | change APPROVED and MERGED [by jenkins-bot]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links