Last modified: 2013-08-19 04:48:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50211, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48211 - Duplicate ULS dialogs in page source
Duplicate ULS dialogs in page source
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Santhosh Thottingal
code-quality
:
: 48423 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-07 13:29 UTC by Niklas Laxström
Modified: 2013-08-19 04:48 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2013-05-07 13:29:59 UTC 
1) Go to https://dev.translatewiki.net/w/i.php?title=Special:MainPage&uselang=he
2) Click few input fields (search, search in group selector)
3) Observe the page source (dynamically updated, not the static one)

Observed: Four or more <div ... class="grid uls-menu uls-wide">...</div>.

Expected: Only one.

Having more than one is usually waste of resources.
Comment 1 Nemo 2013-05-15 06:07:09 UTC 
*** Bug 48423 has been marked as a duplicate of this bug. ***
Comment 2 Gerrit Notification Bot 2013-05-15 09:19:52 UTC 
Related URL: https://gerrit.wikimedia.org/r/63830 (Gerrit Change I78ad47b1875f9f6f40707fb05f948c939fe91b39)
Comment 3 Santhosh Thottingal 2013-05-15 09:22:03 UTC 
Even though we need to avoid unnecessary duplication of ULS windows, please note that depending on context we show different ULS dialogs

1) One with language settings at the settings block(bottom of dialog
2) ULS triggered from more languages buttons- without settings icons at the bottom
Comment 4 Santhosh Thottingal 2013-05-16 04:56:55 UTC 
(In reply to comment #2)
> Related URL: https://gerrit.wikimedia.org/r/63830 (Gerrit Change
> I78ad47b1875f9f6f40707fb05f948c939fe91b39)

This was reverted in Gerrit change #63906 because of a regression
Comment 5 Santhosh Thottingal 2013-07-24 11:13:05 UTC 
Patch:
https://gerrit.wikimedia.org/r/75564 and https://gerrit.wikimedia.org/r/#/c/75574
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links