Last modified: 2013-07-25 07:07:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50220, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48220 - Move pull requests from github to gerrit
Move pull requests from github to gerrit
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Indrani
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-07 17:05 UTC by Željko Filipin
Modified: 2013-07-25 07:07 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Željko Filipin 2013-05-07 17:05:03 UTC
https://github.com/wikimedia/qa-browsertests/pulls
Comment 1 Indrani 2013-05-07 22:09:19 UTC
I have created Gerrit and bugzilla accounts.

However I am not able to git push my changes. Please find the error log below

User@HP /git/browsertests (master)
$ git push ssh://indrani@gerrit.wikimedia.org:29418/qa/browsertests HEAD
Counting objects: 7, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 897 bytes, done.
Total 4 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Branch refs/heads/master:
remote: You are not allowed to perform this operation.
remote: To push into this reference you need 'Push' rights.
remote: User: indrani
remote: Please read the documentation and contact an administrator
remote: if you feel the configuration is incorrect
remote: Processing changes: refs: 1, done
To ssh://indrani@gerrit.wikimedia.org:29418/qa/browsertests
 ! [remote rejected] HEAD -> master (prohibited by Gerrit)
error: failed to push some refs to 'ssh://indrani@gerrit.wikimedia.org:29418/qa/
browsertests'
Comment 2 Krinkle 2013-05-07 22:20:32 UTC
(In reply to comment #1)
> I have created Gerrit and bugzilla accounts.
> 
> However I am not able to git push my changes. Please find the error log below

Like pull requests on GitHub, Gerrit uses a model where a change can be proposed before merging it.

However contrary to GitHub, Gerrit also allows a model where changes have to be proposed and reviewed before merging.

Regular git pushes straight to 'master' are not allowed. Instead you push to 'refs/for/master' (the review queue).

See also:
* https://www.mediawiki.org/wiki/Gerrit/Getting_started

But mainly:
* install git-review
* use git review instead of git push
Comment 3 Indrani 2013-05-07 22:42:39 UTC
The following worked fine. I have successfully pushed my changes. 

$ git push ssh://indrani@gerrit.wikimedia.org:29418/qa/browsertests HEAD:refs/f
or/master

Closing this defect
Comment 4 Željko Filipin 2013-05-08 14:52:13 UTC
(In reply to comment #3)
> I have successfully pushed my changes. 

I see 4 pull requests at Github[1], but just two commits in Gerrit[2].

Are you sure you have moved all commits to Gerrit?

Also, please close the pull requests at Github.

If you need help, let me know.

1: https://github.com/wikimedia/qa-browsertests/pulls
2: https://gerrit.wikimedia.org/r/#/q/owner:littleadventure.09%2540gmail.com+status:open,n,z
Comment 5 Indrani 2013-05-09 12:57:17 UTC
I have commited all 4 in Gerrit now.
https://gerrit.wikimedia.org/r/#/c/62968/

Can you please tell me how to close pull requests at GitHub?
Comment 6 Indrani 2013-05-09 13:03:57 UTC
closed all Github pull requests.
Comment 7 Željko Filipin 2013-05-09 13:50:54 UTC
Indrani, please change bug status from new to resolved. Let me know if you need help with that.
Comment 8 Andre Klapper 2013-05-09 13:51:54 UTC
Thanks! For future commits, http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines might come in handy.
Comment 9 Indrani 2013-05-09 13:54:23 UTC
Bug status changed to Resolved.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links