Last modified: 2014-02-26 12:55:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50248, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48248 - Defaults override event properties
Defaults override event properties
Status: RESOLVED FIXED
Product: Analytics
Classification: Unclassified
EventLogging (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Ori Livneh
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-08 07:40 UTC by Matthew Flaschen
Modified: 2014-02-26 12:55 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-05-08 07:40:23 UTC 
Because of the order of parameters in the call to extend, the schema defaults override the event's values.

The normal meaning of default would imply the reverse.

I don't know if this can be changed at this point.  If not, the docs should warn you about it.
Comment 1 Ori Livneh 2013-05-08 07:55:15 UTC 
First of all: wow. Good catch. I don't know how this slipped past -- it is egregious.

It looks like we may be saved by the fact that setDefaults was not advertised well and thus not used outside of E3: GuidedTour and GettingStarted are the only instances of setDefault use in the wild that I have been able to identify.
Comment 2 Matthew Flaschen 2013-05-08 08:03:22 UTC 
GuidedTour is okay, since it only uses it for userId and it never overrides that (nor would it make sense too).
Comment 3 Gerrit Notification Bot 2013-05-08 08:31:13 UTC 
Related URL: https://gerrit.wikimedia.org/r/62793 (Gerrit Change Id14ba276329272c41370458d5330599a725f5419)
Comment 4 spage 2013-06-22 01:05:58 UTC 
Gerrit change is live.
Comment 5 Andre Klapper 2014-02-26 12:55:15 UTC 
[moving from MediaWiki extensions to Analytics product - see bug 61946]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links