Last modified: 2013-05-08 18:21:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50264, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48264 - Site links on Special:MergeAccount all link to same domain
Site links on Special:MergeAccount all link to same domain
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Sam Reed (reedy)
https://login.wikimedia.org/w/index.p...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-08 17:43 UTC by Brion Vibber
Modified: 2013-05-08 18:21 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2013-05-08 17:43:41 UTC
All the site links on Special:MergeAccount:
https://login.wikimedia.org/w/index.php?title=Special:MergeAccount

link to my user page on login.wikimedia.org. They should link to the sites they are listing, eg 'en.wikipedia.org' or 'sc.wiktionary.org' etc.
Comment 1 Sam Reed (reedy) 2013-05-08 17:49:09 UTC
Line 459 onwards of SpecialMergeAccount.php is at fault


See 466 where it's always a local title object:

		$userPageName = Title::makeTitleSafe( NS_USER, $this->mUserName );
		return Xml::element( 'a',
			array(
				'href' => $userPageName->getFullUrl(),
				'title' => $this->msg( 'centralauth-foreign-link',
					$this->mUserName,
					$hostname )->text(),
			),
			$hostname );
Comment 2 Sam Reed (reedy) 2013-05-08 17:50:59 UTC
Vs SpecialCentralAuth.php

		$wikiname = $wiki->getDisplayName();
		return $this->foreignLink(
			$wiki,
			'User:' . $this->mUserName,
			$wikiname,
			$this->msg( 'centralauth-foreign-link', $this->mUserName, $wikiname )->text() );
Comment 3 Gerrit Notification Bot 2013-05-08 17:54:35 UTC
Related URL: https://gerrit.wikimedia.org/r/62839 (Gerrit Change If2c59da4342e0a149b775b4588353eff0106a708)
Comment 4 Alex Monk 2013-05-08 17:55:42 UTC
Caused by Gerrit change #52337
Comment 5 James Forrester 2013-05-08 18:21:07 UTC
Fixed in master by Reedy's code.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links