Last modified: 2013-05-14 15:10:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50325, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48325 - "Add instructor" input popups do not work on mk.wikipedia.org
"Add instructor" input popups do not work on mk.wikipedia.org
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
EducationProgram (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 47787
  Show dependency treegraph
 
Reported: 2013-05-10 15:42 UTC by Sage Ross
Modified: 2013-05-14 15:10 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sage Ross 2013-05-10 15:42:06 UTC
User:Brest ( http://mk.wikipedia.org/wiki/%D0%9A%D0%BE%D1%80%D0%B8%D1%81%D0%BD%D0%B8%D0%BA:Brest ) reports that the "add instructor" popups are not appearing on mk.wikipedia.org, where the extension was just activated.

(He reports that he used Ubuntu 12.04 LTS, Google Chrome, JavaScript enabled.)

Is there something different in the configuration of mk.wikipedia that  causes issues along the lines of bug 39157 ?
Comment 1 Sam Reed (reedy) 2013-05-10 16:51:14 UTC
(In reply to comment #0)
> User:Brest (
> http://mk.wikipedia.org/wiki/
> %D0%9A%D0%BE%D1%80%D0%B8%D1%81%D0%BD%D0%B8%D0%BA:Brest
> ) reports that the "add instructor" popups are not appearing on
> mk.wikipedia.org, where the extension was just activated.

Are not appearing is almost useless.

Where? Pressing what? Javascript console errors?
Comment 2 Andre Klapper 2013-05-10 16:59:16 UTC
I'm missing any steps to reproduce here, so I cannot try anything myself.
Comment 3 Jeroen De Dauw 2013-05-10 17:33:42 UTC
Doubt this is related to bug 39157.

Can you link to a page where this happens?
Comment 4 Jeroen De Dauw 2013-05-10 17:34:52 UTC
I guess I can't try it out regardless since I do not have the appropriate rights on this wiki.
Comment 6 Sage Ross 2013-05-13 19:05:26 UTC
Jeroen and I now have the user rights, and I can confirm the issue. When I click any of the links to add an instructor or volunteer, I get redirected to the top of the page but the js input dialog does not load.
Comment 7 Sam Reed (reedy) 2013-05-13 19:06:03 UTC
(In reply to comment #6)
> Jeroen and I now have the user rights, and I can confirm the issue. When I
> click any of the links to add an instructor or volunteer, I get redirected to
> the top of the page but the js input dialog does not load.

Anything in your JS console?
Comment 8 Sage Ross 2013-05-13 19:21:22 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Jeroen and I now have the user rights, and I can confirm the issue. When I
> > click any of the links to add an instructor or volunteer, I get redirected to
> > the top of the page but the js input dialog does not load.
> 
> Anything in your JS console?

Yes, there's rather a lot of errors in the JS console, but I can't identify what is specific to the EP extension.

Nothing else happens in my JS console after the page loads even when I click the links, so maybe the crud from the banners is preventing the course page JS from loading?
Comment 9 Jeroen De Dauw 2013-05-14 12:00:15 UTC
TypeError: $that.attr(...) is undefined
https://mk.wikipedia.org/w/index.php?title=MediaWiki:JQuery-makeCollapsible.js&action=raw&ctype=text/javascript
Line 229

if ( $that.attr( 'id' ).indexOf( 'mw-customcollapsible-' ) === 0 ) {
Comment 10 Jeroen De Dauw 2013-05-14 12:00:50 UTC
That is not EP code, or particularly related to what the EP code is doing here.
Comment 11 Sam Reed (reedy) 2013-05-14 15:09:18 UTC
https://mk.wikipedia.org/w/index.php?title=%D0%9C%D0%B5%D0%B4%D0%B8%D1%98%D0%B0%D0%92%D0%B8%D0%BA%D0%B8%3AJQuery-makeCollapsible.js&diff=3095264&oldid=1894840

^ Updated it to use the newer version in MW itself, rather than loading an out of date version
Comment 12 Jeroen De Dauw 2013-05-14 15:10:35 UTC
That fixes it. Thanks Reedy!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links