Last modified: 2013-05-15 03:24:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50344, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48344 - Serializer adds newline at the end of some documents
Serializer adds newline at the end of some documents
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-11 00:07 UTC by Roan Kattouw
Modified: 2013-05-15 03:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-05-11 00:07:35 UTC
* Copy the source of http://mediawiki.org/wiki/User:Catrope/Main_Page to your local wiki (running VE master and Parsoid master)
* Open it in VE
* Add a character somewhere, and remove that character using backspace (not using undo)
* The Review and Save button is now available. Click it.
* You should get an empty diff (and in production you currently do). But on my localhost I get a diff that adds a newline to the end.

This happens even when the DOM sent to Parsoid is a full document (https://gerrit.wikimedia.org/r/63251). I've verified there is no newline sent to Parsoid by VE.
Comment 1 Gerrit Notification Bot 2013-05-11 00:42:56 UTC
Related URL: https://gerrit.wikimedia.org/r/63253 (Gerrit Change I479cfc12f49a5e0f28e92217a9ed041fc2e82223)
Comment 2 Gerrit Notification Bot 2013-05-11 01:07:58 UTC
https://gerrit.wikimedia.org/r/63253 (Gerrit Change I479cfc12f49a5e0f28e92217a9ed041fc2e82223) | change APPROVED and MERGED [by jenkins-bot]
Comment 3 Gabriel Wicke 2013-05-12 04:00:38 UTC
Should be fixed by the above commit.
Comment 4 Roan Kattouw 2013-05-14 18:41:01 UTC
(In reply to comment #3)
> Should be fixed by the above commit.
Confirmed fixed with selser enabled but not fixed with selser disabled.
Comment 5 Gerrit Notification Bot 2013-05-14 23:55:58 UTC
Related URL: https://gerrit.wikimedia.org/r/63805 (Gerrit Change Ic20036747f6582741df7e416162029e80b106d8b)
Comment 6 Gerrit Notification Bot 2013-05-15 03:24:16 UTC
https://gerrit.wikimedia.org/r/63805 (Gerrit Change Ic20036747f6582741df7e416162029e80b106d8b) | change APPROVED and MERGED [by jenkins-bot]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links