Last modified: 2013-05-14 20:52:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50345, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48345 - the pop-up help guiders for GS tasks now have a redundant [Okay] buttons
the pop-up help guiders for GS tasks now have a redundant [Okay] buttons
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
master
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-11 04:33 UTC by spage
Modified: 2013-05-14 20:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-05-11 04:33:28 UTC
On enwiki, rolling over the (?) for each task type pops up a single-shot guider. In 1.22wmf3 these now have an [Okay] button. It's distracting and unreachable since the guider dismisses when you move off the (?).
Comment 1 Steven Walling 2013-05-11 04:46:08 UTC
Since we're removing this version next week I don't think we need to devote any time to this issue, but let me explain...

On the iPad and other mobile browsers (that do not redirect to MobileFrontend) that might visit the desktop version of the site, you can't close these guiders unless there is a button. In the future, we can do this with the newly-reintroduced X button.
Comment 2 Matthew Flaschen 2013-05-11 05:11:31 UTC
This is not new.  For instance, if you check out GettingStarted ed5f24e and GuidedTour c42c2f3 (the versions from https://github.com/wikimedia/mediawiki-core/tree/wmf/1.22wmf1/extensions) (1.22wmf1), you'll see the same thing.

Unfortunately, S was not on the thread, but we explicitly decided to do it this way in February.  This was for the benefit of touch users.

As Steven says, this whole screen, including the single-page tour, is gone in master.

But since we're talking about this, I am considering a option (includeAutomaticOkay?), defaulted to true.  It would be set to false to suppress this automatic okay button that shows if there are no other button (and dismisses the current guider).  This is safe for touch now that we have the X button, and will allow suppressing the Okay when more control is desired.  For example, this will be useful if a button must be constructed manually, and the regular Okay is not also wanted.

I already have a use case for this at https://trello.com/card/getting-started-v3/5032806a85f7309c527929de/138 .  See the checkbox item about "Change button text".
Comment 3 Steven Walling 2013-05-14 20:52:38 UTC
Closing since we're launching a new version of the landing page Thursday which won't be subject to this bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links