Last modified: 2013-09-25 15:21:09 UTC
I'm afraid that the current installation of Gerrit is affected by the issue described here https://code.google.com/p/gerrit/issues/detail?id=1862 which was fixed later for the 2.6 release. Would it be possible to upgrade the installation? Or at least patch it against this issue?
I am not completely sure what you are referring to, as the bug you link to refers to auth.type = http. While puppet tells me that we're on ldap. But since the bug you mentioned is about circular redirects, I tried navigating to https://gerrit.wikimedia.org . That correctly takes me to https://gerrit.wikimedia.org/r/#/ and I get to see my dashboard. Looks correct. If I am not logged in, navigating to https://gerrit.wikimedia.org takes me to https://gerrit.wikimedia.org/r/#/q/status:open,n,z and I get to see the changes with open status. Looks correct as well. Clicking on „Sign in” on that page takes me to https://gerrit.wikimedia.org/r/login/q/status:open,n,z and I can enter my LDAP credentials to log in. Upon logging in, I am forwarded again to https://gerrit.wikimedia.org/r/#/q/status:open,n,z , which also looks correct. So I cannot reproduce circular redirects. Which URL does not work for you?
(In reply to comment #2) > Which URL does not work for you? Check the comment at https://bugs.eclipse.org/bugs/show_bug.cgi?id=395059#c3 I found this issue while trying to connect my Eclipse Mylyn.
(In reply to comment #1) > https://code.google.com/p/gerrit/issues/detail?id=1862 > > which was fixed later for the 2.6 release. Would it be possible to upgrade > the installation? The patch for this issue has already been included in our gerrit some time ago. (In reply to comment #3) > > Which URL does not work for you? > [...] > I found this issue while trying to connect my Eclipse Mylyn. Is the bug about Mylyn's Gerrit connector not being able to validate http://gerrit.wikimedia.org/r as task repository? If so, our gerrit isn't too old, but to new :-) The (still open) bug at https://bugs.eclipse.org/bugs/show_bug.cgi?id=395059 that you mentioned states that Mylyn's Gerrit connector has not yet been ported to the new RPC infrastructure that comes with Gerrit 2.6.
(In reply to comment #4) > The patch for this issue has already been included in our gerrit > some time ago. Great, that's really what I needed to know. I'll close this bug then, since it is invalid. > (In reply to comment #3) > The (still open) bug at > https://bugs.eclipse.org/bugs/show_bug.cgi?id=395059 > that you mentioned states that Mylyn's Gerrit connector has not yet > been ported to the new RPC infrastructure that comes with Gerrit 2.6. Yes, my concern was that, even if I wanted to hack Egit's source to connect Mylyn with Wikimedia's Gerrit, the other bug would still bite me.
As reported on http://lists.wikimedia.org/pipermail/wikitech-l/2013-September/071862.html it seems that latest nightlies of mylyn review come with support for newer gerrits and can be used to connect to our gerrit again \o/
It doe(In reply to comment #6) > As reported on > > http://lists.wikimedia.org/pipermail/wikitech-l/2013-September/071862.html > > it seems that latest nightlies of mylyn review come with support for newer > gerrits and can be used to connect to our gerrit again \o/ It doesn't support inline comments yet, but it is in the works.
