Last modified: 2013-05-13 18:00:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50370, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48370 - Remove redundant "patrolmarks" right
Remove redundant "patrolmarks" right
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
https://es.wikipedia.org/wiki/Especia...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-12 06:58 UTC by Nemo
Modified: 2013-05-13 18:00 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2013-05-12 06:58:09 UTC
Some wikis assign "patrolmarks" right to some group, but the right has no effect: only users with "patrol" permission can see patrol marks, see for instance es.wiki RC where the config is
    '*' => array( 'patrolmarks' => true ),
but I can't see any patrol mark. If this ever worked, it now doesn't, so the config should be removed: seems to be trivial cleanup.

For the background: this behaviour makes sense because the others are only bothered by it, however there's a comment by Krinkle in bug 37966 comment 2 which I don't understand (if the right is implied by "patrol" and doesn't work, why assign it?). Siebrand mentioned confusion in bug 19067. At some point FlaggedRevs made all editors see patrol marks, bug 24053 (but this changed after April 2012, compare https://www.mediawiki.org/?oldid=526311 https://www.mediawiki.org/?diff=688799 ).
Comment 1 Umherirrender 2013-05-13 17:31:05 UTC
'patrol' let you patrol pages and see the markers.
'patrolmarks' only let you see the markers.

Markers only shown for pages, which are *not* marked as patrolled. I can see a red ! near to some pages on [[es:Special:RecentChanges]]. But for eswiki only wgUseNPPatrol is true, so you can see that ! only at new pages. The yellow background on [[es:Special:NewPages]] are all unpatrolled pages.

WORKSFORME
Comment 2 Nemo 2013-05-13 18:00:33 UTC
Ah, thank you, I now understand Krinkle's "can't be separated". :)
So apart from the confusion with the changes in FlaggedRevs I guess there's no actual problem.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links