Last modified: 2013-08-29 07:06:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50458, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48458 - debug=true causes broken UI due to add_messages() code in gateway_forms/RapidHtml.php
debug=true causes broken UI due to add_messages() code in gateway_forms/Rapid...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
DonationInterface (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-14 16:34 UTC by Mark Holmquist
Modified: 2013-08-29 07:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2013-05-14 16:34:26 UTC
{% block personal-information country %}
%donate_interface-amount-legend%: {% block donation-amount currency_code %}

These are just some of the messages I get from MediaWiki when I try to load Special:GlobalCollectGateway with debug=true.

Ideally debug=true would be a good way to find JavaScript bugs, but right now, it's impossible to see where JS errors are actually coming from.
Comment 1 Adam Wight 2013-05-14 17:32:44 UTC
Interesting.  I've been worried about the inconsistent way "debug" is handled: in some places it is checked using getFuzzyBool, and in other places, simple equality.

Can you try "debug=1" as a workaround?
Comment 2 Mark Holmquist 2013-05-14 17:40:27 UTC
That's a valid workaround, I guess. I can take a look at this for convenience (because a year of typing debug=true likely won't lend itself to overnight change...)
Comment 3 Matthew Flaschen 2013-05-14 21:36:01 UTC
FWIW, it seems to be exclusively FuzzyBool in core (based on "git grep get.*Bool.*debug"), so that's probably how it should be here.
Comment 4 Adam Wight 2013-05-15 05:25:41 UTC
marktraceur: gross, I found the culprit,
gateway_forms/RapidHtml.php line 256, in add_messages()

<pre>
        if( $wgRequest->getText( 'debug', 'false' ) == 'true' ){
            # do not replace tokens
</pre>

So, that's just terrible since it actually breaks debugging.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links