Last modified: 2013-10-13 18:56:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50480, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48480 - Remove EmailCapture extension
Remove EmailCapture extension
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Tomasz W. Kozlowski
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-15 00:04 UTC by MZMcBride
Modified: 2013-10-13 18:56 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-05-15 00:04:49 UTC
From <https://noc.wikimedia.org/conf/InitialiseSettings.php.txt>:

---
'wgUseEmailCapture' => array(
	'default' => false,
	'testwiki' => true,
	'enwiki' => true,
),
---

This variable should be investigated. I'm not sure enwiki and testwiki should be true any longer. At a minimum, it'd be nice to annotate the entry so I'm not left wondering.
Comment 1 Matthew Flaschen 2013-05-15 10:19:52 UTC
This is for https://www.mediawiki.org/wiki/Extension:EmailCapture .  I don't know if it was ever deployed, but it says it was for the original ArticleFeedback extension.
Comment 2 Nemo 2013-10-07 21:44:59 UTC
There's also:
----
// Email capture
// NOTE: Must be BEFORE ArticleFeedback
if ( $wgUseEmailCapture ) {
	include( "$IP/extensions/EmailCapture/EmailCapture.php" );
	$wgEmailCaptureAutoResponse['from'] = 'improve@wikimedia.org';
}
----
https://noc.wikimedia.org/conf/highlight.php?file=CommonSettings.php

AFAIK this has been disabled for months if not years; it's listed as requirement for AFTv4 at [[mw:Extension:ArticleFeedback]] but not for AFTv5 and IIRC the CTA using EmailCapture didn't last long even though it's mentioned in [[mw:Article_feedback/Version_5/Feature_Requirements]]:
«It may also be possible to adapt the post-survey CTA from AFT v4, with some minor changes to the wording (see this screenshot of a current AFTv4 email capture form, for reference).»
There's no reference to EmailCapture in AFTv5's code and AFTv4 is disabled everywhere:

'wmgUseArticleFeedback' => array(
	'default' => false,
),

AFT-related clutter should also be removed from  mediawiki/tools/release/make-wmf-branch/default.conf btw.
Comment 3 Gerrit Notification Bot 2013-10-08 09:31:50 UTC
Change 88424 had a related patch set uploaded by Odder:
(bug 48480) Remove EmailCapture extension settings

https://gerrit.wikimedia.org/r/88424
Comment 4 Tomasz W. Kozlowski 2013-10-08 13:09:40 UTC
(In reply to comment #2)
 
> AFT-related clutter should also be removed from 
> mediawiki/tools/release/make-wmf-branch/default.conf btw.

I'll remove the EmailCapture bit, but will leave ArticleFeedback (v4) be for the time being; we have a lot of code associated with it in CommonSettings.php /and/ InitialiseSettings.php, so it'll need a bug of its own.
Comment 5 Gerrit Notification Bot 2013-10-08 13:14:02 UTC
Change 88457 had a related patch set uploaded by Odder:
(bug 48480) Clean-up EmailCapture extension config

https://gerrit.wikimedia.org/r/88457
Comment 6 Gerrit Notification Bot 2013-10-10 17:32:46 UTC
Change 88457 merged by jenkins-bot:
(bug 48480) Clean-up EmailCapture extension config

https://gerrit.wikimedia.org/r/88457
Comment 7 Nemo 2013-10-10 19:27:06 UTC
Fixed, it seems.
Comment 8 Tomasz W. Kozlowski 2013-10-10 20:08:05 UTC
Not yet, see https://gerrit.wikimedia.org/r/#/c/88424/
Comment 9 Gerrit Notification Bot 2013-10-11 18:12:11 UTC
Change 88424 merged by jenkins-bot:
(bug 48480) Remove EmailCapture extension settings

https://gerrit.wikimedia.org/r/88424
Comment 10 MZMcBride 2013-10-13 18:56:08 UTC
Filed bug 55676 to track removing the associated database table from Wikimedia wikis.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links