Last modified: 2014-06-09 21:36:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50507, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48507 - mw.hook listeners for GuidedTour for shouldSkip
mw.hook listeners for GuidedTour for shouldSkip
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Matthew Flaschen
: tracking
Depends on:
Blocks: 51985
  Show dependency tree / graph
 
Reported: 2013-05-15 10:15 UTC by Matthew Flaschen
Modified: 2014-06-09 21:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-05-15 10:15:11 UTC 
Investigate how mw.hook could be useful for GuidedTour.  One idea is subscribing to state changes for shouldSkip.  For instance, UploadWizard has an AJAX-type interface where you go from step to step without changing pages.

If we could listen to those steps, we could trigger the shouldSkip check (by calling guiders.resume or maybe another method that only checks this).
Comment 1 Matthew Flaschen 2013-07-05 23:35:39 UTC 
I'm working on a change set right now that uses mw.hook for VE like this.
Comment 2 Matthew Flaschen 2013-07-24 19:13:57 UTC 
This is done for VisualEditor.  I made this a tracking bug, and opened a separate one (bug 51985) for UploadWizard.
Comment 3 Gerrit Notification Bot 2014-04-17 04:11:32 UTC 
Change 116228 had a related patch set uploaded by Mattflaschen:
WIP: Refactor and add non-linear tours, with tests

https://gerrit.wikimedia.org/r/116228
Comment 4 Gerrit Notification Bot 2014-06-09 16:56:34 UTC 
Change 116228 merged by jenkins-bot:
Refactor and add non-linear tours, with tests

https://gerrit.wikimedia.org/r/116228
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links