Last modified: 2014-02-12 23:52:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50512, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48512 - French Nearby doesn't work (If geodata is not installed the special page should 404)
French Nearby doesn't work (If geodata is not installed the special page shou...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-15 17:58 UTC by Jon
Modified: 2014-02-12 23:52 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2013-05-15 17:58:34 UTC
https://fr.m.wikipedia.org/wiki/Sp%C3%A9cial:Nearby doesn't work < no geodata installed?
Comment 1 Jon 2013-05-15 17:59:10 UTC
If geodata is not installed the special page should 404.
Comment 2 Jon 2013-05-15 18:17:34 UTC
Let's set $wgMFNearby = false on all projects that don't have geodata or any data...
Comment 3 Arthur Richards 2013-05-15 22:39:56 UTC
GeoData is enabled on French Wikipedia, unless I am reading configuration wrong. 

Have you confirmed with someone in France that Special:Nearby is not working on frwiki? If you used the feature from SF it's possible there really are no frwiki articles nearby.

I did notice on fr.m.wikipedia.org/wiki/Special:Nearby I receive a JS error:

Uncaught TypeError: Cannot read property 'pages' of undefined nearby.js:137
(anonymous function) nearby.js:137
fire load.php:974
self.fireWith load.php:1084
done load.php:7803
callback

Perhaps because there are no results? Fwiw, I see the same error on http://es.m.wikipedia.org/wiki/Especial:Nearby

BTW I am checking these from Monterey, CA.
Comment 4 Jon 2013-05-15 22:43:54 UTC
The API currently responds with:
{"limits":{"coordinates":500}}

A successful result however is expected to look like this:

{"query":{"pages":{"20004112":{"pageid":20004112,"ns":0,"title":"The Montgomery (San Francisco)","thumbnail":{"source":"https://upload.wikimedia.org/wikipedia/commons/thumb/b/b1/The_Montgomery%2C_San_Francisco.jpg/119px-The_Montgomery%2C_San_Francisco.jpg","width":119,"height":180},"pageimage":"The_Montgomery,_San_Francisco.jpg","coordinates":[{"lat":37.787,"lon":-122.4,"primary":""}]} 
,"limits":{"coordinates":500}}

If the API is returning no results it should respond with
{"query":{"pages":{}}, "limits":{"coordinates":500} }

We have too much special casing of all the edge error cases in the API. Let's not introduce even more...
Comment 5 Gerrit Notification Bot 2013-05-16 19:33:48 UTC
Related URL: https://gerrit.wikimedia.org/r/64120 (Gerrit Change Id3cb6fcf3c7bc268ddab4edb5bade56a7a595b73)
Comment 6 Jon 2013-05-16 19:36:45 UTC
Sigh.. ^
Comment 7 Gerrit Notification Bot 2013-05-16 23:18:37 UTC
https://gerrit.wikimedia.org/r/64120 (Gerrit Change Id3cb6fcf3c7bc268ddab4edb5bade56a7a595b73) | change APPROVED and MERGED [by Jdlrobson]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links