Last modified: 2013-05-18 10:14:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50542, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48542 - Special:Statistics - content language takes precedence over user language
Special:Statistics - content language takes precedence over user language
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.22.0
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: MWJames
: i18n
Depends on:
Blocks: 48537
  Show dependency treegraph
 
Reported: 2013-05-16 15:20 UTC by [[kgh]]
Modified: 2013-05-18 10:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description [[kgh]] 2013-05-16 15:20:44 UTC
Special:Statistics utilises the content language and not the user language in case an extension adds information to it.

This issue emerged during the problem investigation on 48537. A fix was proposed for core to resolve this (48537#c2).
Comment 1 [[kgh]] 2013-05-16 15:24:50 UTC
Adding further information: keywords, target milestone (little wish), assigned to and changing importance to normal normal
Comment 2 MWJames 2013-05-16 15:34:41 UTC
The required change:

SpecialStatistics/line 301 from

$name = $this->msg( $key )->inContentLanguage()->parse();

to

$name = $this->msg( $key )->parse();
Comment 3 Andre Klapper 2013-05-16 16:43:48 UTC
No 1.21.0 material as release is imminent.
Comment 4 [[kgh]] 2013-05-16 16:47:58 UTC
Fair enough though I had hoped that somehow moving a fix into the 1.21 branch might be within the range of possibility even after the first release.
Comment 5 Gerrit Notification Bot 2013-05-16 16:50:41 UTC
Related URL: https://gerrit.wikimedia.org/r/64087 (Gerrit Change Ib7d9cb5aa3051b5d602f7a0838425d92fc7a515f)
Comment 6 MWJames 2013-05-16 16:55:47 UTC
Andre, could you assign a reviewer for the patch (last time it took 5 month).
Comment 7 Bawolff (Brian Wolff) 2013-05-16 17:12:54 UTC
(In reply to comment #6)
> Andre, could you assign a reviewer for the patch (last time it took 5 month).

I just reviewed your patch (It is after all a 1 line fix).

----

Marking this bug as fixed. In regards to backporting the fix - personally I don't think the issue is severe enough to warrant backporting. However if you feel strongly it should be, maybe run it by hexmode to see if he thinks it should be backported.
Comment 8 Mark A. Hershberger 2013-05-16 18:54:47 UTC
It is a one line fix.  I don't have a problem adding this before release and it will help some users.

So that I can do this quickly, someone needs to provide a gerrit change with an update to the release notes that will make it so that I only have to verify the change to have it merged.
Comment 9 Gerrit Notification Bot 2013-05-16 19:22:37 UTC
Related URL: https://gerrit.wikimedia.org/r/64112 (Gerrit Change Ib7d9cb5aa3051b5d602f7a0838425d92fc7a515f)
Comment 10 [[kgh]] 2013-05-18 10:14:03 UTC
Just wanted to say that all of you are awesome. Thank you for dealing with this!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links