Last modified: 2013-05-20 23:02:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50547, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48547 - Echo: Pagelink notifications triggered on template update
Echo: Pagelink notifications triggered on template update
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-16 18:49 UTC by Oliver Keyes
Modified: 2013-05-20 23:02 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-05-16 18:49:50 UTC
If an article has a navbox (say, https://en.wikipedia.org/wiki/Template:William_Blake) updates to it that add links trigger pagelink notifications, which might be confusing. Is there any way we can essentially blacklist the template namespace?
Comment 1 Ryan Kaldari 2013-05-16 20:31:50 UTC
From where we are triggering the notification, I'm pretty sure there is no way to differentiate, but it would be good to double-check.
Comment 2 Erik Bernhardson 2013-05-20 22:52:06 UTC
I took a look through the code to double check what is available in the LinksUpdateAfterInsert hook which page-linked notifications are fired from. Unfortunately I'm also not seeing any way to differentiate between links generated from a template and links generated due to other means.  

The parser itself replaces templates with static wiki text fairly early in the rendering process, so it has no clue where the links came from and cant tell us.

I briefly looked at if we could do something based on a list of templates that are used in the page, but since templates have conditionals i don't see it viable to attempt to look at the templates to determine what links to not generate notifications for.

There may be ways to do it, but nothing is jumping out at me.
Comment 3 Ryan Kaldari 2013-05-20 23:02:09 UTC
I think I'm going mark this one WONTFIX as it would be quite difficult technically to differentiate template links from other links. We would probably have to do some significant hacking in core and it doesn't sound like the benefit would be worth the additional overhead of tracking that information through the rendering process.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links