Last modified: 2014-02-12 23:55:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50551, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48551 - Formatter: Skin code in MobileFormatter
Formatter: Skin code in MobileFormatter
Status: RESOLVED INVALID
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Max Semenik
:
Depends on:
Blocks: 43271
  Show dependency treegraph
 
Reported: 2013-05-16 21:47 UTC by Jon
Modified: 2014-02-12 23:55 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2013-05-16 21:47:18 UTC
There are various bits of HTML that are added in MobileFormatter that would better belong in the Skin itself.

These include back to top link, content_block, section_heading and section classes.

It would be better for the skin to be given a data structure describing the sections similar to what the API returns and let the template (MinervaTemplate) decide how to format this.

It would also be useful to make this less mobile specific so it can be used on the desktop Minerva skin.
Comment 1 Jon 2013-05-16 21:48:08 UTC
https://gerrit.wikimedia.org/r/#/c/64104/ was a first stab to try and explain this better.
Comment 2 Jon 2013-06-05 18:53:16 UTC
This would also allow us to ensure that content_0 is present on all pages and allow us to run photo uploads CTA on the desktop version of Minerva.
Comment 3 Jon 2013-06-13 17:59:47 UTC
Max appears to be working on this.
Comment 4 Jon 2013-07-05 19:29:02 UTC
To clarify this bug was about moving more control to the template (I got confused with the word skin). It seems ideally that some changes would need to be upstreamed to core for this to happen.

Proof of concept:
https://gerrit.wikimedia.org/r/#/c/70736/
Comment 5 Jon 2013-09-24 22:42:16 UTC
I would like to propose we move the formatter code as it is now into SkinMinerva/the Skin class in core so that the desktop Minerva skin can make use of it are there any blockers to doing this?
Comment 6 Jon 2013-11-12 18:09:45 UTC
Since SkinMinerva and the formatter have changed drastically this problem doesn't seem so relevant now so closing.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links