Last modified: 2013-06-24 09:24:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50554, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48554 - Enable phpunit tests for Echo
Enable phpunit tests for Echo
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Unprioritized trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-16 22:52 UTC by James Forrester
Modified: 2013-06-24 09:24 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-05-16 22:52:45 UTC 
Per Matt's comment on https://gerrit.wikimedia.org/r/#/c/63789/
Comment 1 Gerrit Notification Bot 2013-05-20 08:44:59 UTC 
Related URL: https://gerrit.wikimedia.org/r/64555 (Gerrit Change Ibc5db93c6c8e49cb11e50d67ed8811c0b6dd7bb7)
Comment 2 Antoine "hashar" Musso (WMF) 2013-05-20 08:49:17 UTC 
I have tried out with a lame change ( https://gerrit.wikimedia.org/r/#/c/36967/ ) the new patchset did trigger the tests: https://integration.wikimedia.org/ci/job/mwext-Echo-testextensions-master/315/

Note that they are currently failing apparently due to some database transaction already being in progress (Jenkins as the development warnings enabled).

Hence, Jenkins is not blocking when tests are failing.
Comment 3 Erik Bernhardson 2013-06-14 18:40:44 UTC 
I have solved and closed the bug with Echo failing to run on sqlite.  We should be good now to enable voting for the test runner.
Comment 4 Gerrit Notification Bot 2013-06-24 09:23:07 UTC 
Related URL: https://gerrit.wikimedia.org/r/70130 (Gerrit Change I5796acce6dccf5ee4d63b84dcce796ee5a2d7c2f)
Comment 5 Antoine "hashar" Musso (WMF) 2013-06-24 09:24:23 UTC 
Made the unit tests voting again :-]   Thank you for the fix!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links