Last modified: 2013-06-22 19:58:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50562, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48562 - GettingStarted toolbar can overflow if window is less than 1000px wide
GettingStarted toolbar can overflow if window is less than 1000px wide
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-16 23:56 UTC by spage
Modified: 2013-06-22 19:58 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
display in Firefox in a 900px-wide window (257.52 KB, image/png)
2013-05-16 23:56 UTC, spage
Details

Description spage 2013-05-16 23:56:25 UTC
Created attachment 12330 [details]
display in Firefox in a 900px-wide window

GettingStarted's task toolbar can overflow and look weird if your window isn't wide enough. See attached screenshot, note buttons and close boxes appearing outside the dark background. It happened to me half-HD screen window (960px wide), but that's because I zoom fonts; At 100% the overflow happens at around 905px in Firefox.

The appearance glitches are similar in Chrome.

Changing mw-gettingstarted-toolbar to "display: table" greatly improves the appearance at narrow widths in Firefox but causes other problems in Chromium.
Comment 1 Matthew Flaschen 2013-05-17 00:00:01 UTC
It's complicated by the way the page is being shifted for the toolbar, but this can probably be improved with media queries.  We just need to choose an alternative layout (probably requiring more toolbar height) for small-width screens like this.

CCing the designers.
Comment 2 Steven Walling 2013-05-17 01:02:04 UTC
Yes, since the beginning of this (i.e. the prototyping and testing) we knew that anything smaller than 1024x768 would get a slightly broken-looking toolbar. 

For the purposes of the test, the number of desktop users who regularly use windows with a width of less than 1000 is small enough not pervert the test results, but when we move to productize this, this should be fixed. FWIW: in Chrome on OSX, I can get down to 910px without overflow.
Comment 3 Matthew Flaschen 2013-05-17 01:04:29 UTC
I could use some help from the designers in crafting alternative CSS and appearance.  If they just tell me (e.g. "use this alternative CSS for under 950px width", I can implement that pretty easily.
Comment 4 Steven Walling 2013-06-11 22:07:07 UTC
(In reply to comment #1)
> It's complicated by the way the page is being shifted for the toolbar, but
> this
> can probably be improved with media queries.  We just need to choose an
> alternative layout (probably requiring more toolbar height) for small-width
> screens like this.
> 
> CCing the designers.

Okay, this issue has lingered enough. If Pau and May are comfortable, I'd like to rectify this sooner rather than later, and simply hide the toolbar at small sizes. Say, anything under 900 width? 

Until we come up with a smarter responsive design (say, hiding the center elements in the toolbar and reducing it to the "Back to list" and "Try another article" elements?), we can prevent broken views of the toolbar. 

Out of curiosity, I retested this on in the iPad simulator (which gets redirected to desktop Vector, not MobileFrontEnd) and the toolbar works just fine.
Comment 5 Matthew Flaschen 2013-06-17 21:46:11 UTC
I'm on this now.  I'm first working on expanding the toolbar height, so it's usable at a smaller resolution.  If that doesn't work, I can just hide it.
Comment 6 Gerrit Notification Bot 2013-06-18 06:21:51 UTC
Related URL: https://gerrit.wikimedia.org/r/69282 (Gerrit Change I44a472e97e99f4107a964f64422e7892533d194b)
Comment 7 Matthew Flaschen 2013-06-18 06:23:15 UTC
Okay, this isn't perfect, but it significantly improves matters.
Comment 8 Steven Walling 2013-06-18 18:23:51 UTC
(In reply to comment #7)
> Okay, this isn't perfect, but it significantly improves matters.

Yep, this works fairly well down to about 850px wide. I'd still ideally like to hide the toolbar below that size, but I think this patch works.
Comment 9 Matthew Flaschen 2013-06-20 05:06:49 UTC
Done and on Piramido for testing.

Do we want to log that for Analytics purposes (whether they saw the toolbar)?
Comment 10 Matthew Flaschen 2013-06-22 19:58:19 UTC
Merged and deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links