Last modified: 2013-05-21 08:26:14 UTC
We're starting to create puppet module repositories under operations/puppet/*. We should enable automatic linting for repositories. This should work the same way it does for the operations/puppet repository. While we're at it, what about running puppet unit tests? The operations/puppet/cdh4 repository has them! (Thanks Alex!)
Need to do something like the erb linter. Working on it.
Related URL: https://gerrit.wikimedia.org/r/64427 (Gerrit Change I66fca52afc87b00b7d77ff4adead2547211a39db)
INFO:jenkins_jobs.builder:Creating jenkins job operations-puppet-cdh4-erblint-HEAD INFO:jenkins_jobs.builder:Creating jenkins job operations-puppet-cdh4-pplint-HEAD INFO:jenkins_jobs.builder:Creating jenkins job operations-puppet-kafka-erblint-HEAD INFO:jenkins_jobs.builder:Creating jenkins job operations-puppet-kafka-pplint-HEAD
Related URL: https://gerrit.wikimedia.org/r/64432 (Gerrit Change I0cb06d78188f82cfad25477c86e94660954f3061)
Related URL: https://gerrit.wikimedia.org/r/64438 (Gerrit Change If043e1db3d470cf326a66776113c03c4a056e42d)
Of course I made some tiny mistakes that would have been catched by a proper "pre commit" review workflow. But got them fixed and that seems to work now. I have triggered the jobs on cdh4 and hadoop modules by filling in Gerrit a 'recheck' comment. Tests changes: Kafka: https://gerrit.wikimedia.org/r/50385 Cdh4: https://gerrit.wikimedia.org/r/61710
Looks great! We should get unit testing in too sometime. Will resolve this for now.
On second thought, I forgot to create the '-merge' jobs and make them the first one in the template. Will poke that monday (or later next week).
Related URL: https://gerrit.wikimedia.org/r/64783 (Gerrit Change I60530800226f7d9aecf61c3e53db055d26178f66)
Related URL: https://gerrit.wikimedia.org/r/64784 (Gerrit Change Ic7cc463b5518ae40f29b4a077f2342186cb64470)
Well merge jobs are not really needed since the test jobs are very fast. I reverted the two above changes.
