Last modified: 2013-07-18 12:01:30 UTC
Original Bug title: Icon-only-buttons broken in vector broken by https://bits.wikimedia.org/static-1.22wmf4/resources/jquery.ui/themes/vector/jquery.ui.button.css body .ui-button { /*...*/ width: auto /*...*/ } which overwrites button.ui-button-icon-only { width: 2.4em } Test case (can be executed in a JS console): $button = $('<button>').text('required but not visible').button({ icons: { primary: "ui-icon-locked" }, text: false }); mw.util.$content.prepend($button);
Created attachment 12335 [details] rendering of broken vector button
Created attachment 12336 [details] expected result
Created attachment 12337 [details] new proposed content of resources/jquery.ui/themes/vector/jquery.ui.button.css
Created attachment 12338 [details] Patch to apply against resources/jquery.ui/themes/vector/jquery.ui.button.css
Thanks! Anybody is welcome to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this patch as a Git branch directly into Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial so the patch can get reviewed and merged into the codebase.
Obviously no one wanted. Isn't there a way to submit a patch to gerrit quickly? A web-interface like github has, perhaps?
Gerrit notification: https://gerrit.wikimedia.org/r/74345
(In reply to comment #6) > Obviously no one wanted. Isn't there a way to submit a patch to gerrit > quickly? A web-interface like github has, perhaps? No, but it may or may not be in the works. (Currently you can already edit commit messages from the web interface using the little pencil icon on its top-right corner.)
Change 74345 had a related patch set uploaded by Matmarex: Fixing width of icon-only-buttons in Vector skin https://gerrit.wikimedia.org/r/74345
Merged.
Change 74345 merged by jenkins-bot: Fixing width of icon-only-buttons in Vector skin https://gerrit.wikimedia.org/r/74345
