Last modified: 2013-05-22 13:40:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50621, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48621 - changing a Snak's time value from a valid to an invalid one will not disable Claim's "save" button
changing a Snak's time value from a valid to an invalid one will not disable ...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-19 21:55 UTC by Daniel A. R. Werner
Modified: 2013-05-22 13:40 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel A. R. Werner 2013-05-19 21:55:07 UTC 
Changing a "time" value from a valid to an invalid value will not trigger the "save" button to be disabled. When saving, the previously valid value will be saved.

The reason for this is that the jQuery.valueview.experts.TimeInput instance won't notify about the change from valid to invalid. Probably because the jQuery.time.timeinput's "update" event only triggers when the value changes to another valid value.

Note: this should be a bug in the "ValueView" extension which is not yet available in bugzilla.
Comment 1 Daniel A. R. Werner 2013-05-19 22:03:06 UTC 
Update: the "update"/"change" events/notifications get passed along well. The rawValue() of the expert is the problem. It always remains the same, even if it should reflect the invalid value and not return a time value.
Comment 2 Daniel A. R. Werner 2013-05-19 22:16:26 UTC 
Within the expert's _getRawValue(), this._newValue is 'undefined' even though it should be 'false' in the case described above. Not sure how this could happen. If it were 'false', the right value would be returned.
Comment 3 Gerrit Notification Bot 2013-05-19 23:59:57 UTC 
Related URL: https://gerrit.wikimedia.org/r/64541 (Gerrit Change Ieb37ba7ea544c37421e38ddef21acef901b26523)
Comment 4 Gerrit Notification Bot 2013-05-21 10:33:34 UTC 
https://gerrit.wikimedia.org/r/64541 (Gerrit Change Ieb37ba7ea544c37421e38ddef21acef901b26523) | change APPROVED and MERGED [by jenkins-bot]
Comment 5 abraham.taherivand 2013-05-22 13:40:58 UTC 
Verified in Wikidata demo sprint 22-5
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links