Last modified: 2013-05-22 13:41:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50622, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48622 - JavaScript UI fails if entity page data model contains unexpected DataValues JSON
JavaScript UI fails if entity page data model contains unexpected DataValues ...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
Storypoints: 5
: javascript
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-19 23:53 UTC by Daniel A. R. Werner
Modified: 2013-05-22 13:41 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel A. R. Werner 2013-05-19 23:53:50 UTC 
If on an entity page the JSON representing the entity contains some unexpected values in a Snak's DataValues JSON, the UI will fail to initialize.

This can be the case for various reasons. Currently it is the case for Time values where the JSON contains an unknown calendar model. Since the backend doesn't check for known calendar models, it is easy to inject such data via the API.
The Frontend should not fail but rather display a warning that a value was not successfully unserialized.
Comment 1 Gerrit Notification Bot 2013-05-19 23:59:59 UTC 
Related URL: https://gerrit.wikimedia.org/r/64543 (Gerrit Change I4dba21975c6592050167f527c9dddcc734df9041)
Comment 2 Gerrit Notification Bot 2013-05-20 00:03:09 UTC 
Related URL: https://gerrit.wikimedia.org/r/64545 (Gerrit Change I4f9215add1f3e964f229cbe222e9b0562045648d)
Comment 3 Gerrit Notification Bot 2013-05-21 10:50:34 UTC 
https://gerrit.wikimedia.org/r/64543 (Gerrit Change I4dba21975c6592050167f527c9dddcc734df9041) | change APPROVED and MERGED [by jenkins-bot]
Comment 4 Gerrit Notification Bot 2013-05-21 11:14:54 UTC 
https://gerrit.wikimedia.org/r/64545 (Gerrit Change I4f9215add1f3e964f229cbe222e9b0562045648d) | change APPROVED and MERGED [by jenkins-bot]
Comment 5 abraham.taherivand 2013-05-22 13:41:06 UTC 
Verified in Wikidata demo sprint 22-5
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links