Last modified: 2013-06-13 18:28:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50638, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48638 - FlaggedRevs stable version does not use ContentHandler
FlaggedRevs stable version does not use ContentHandler
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-20 14:58 UTC by Umherirrender
Modified: 2013-06-13 18:28 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2013-05-20 14:58:40 UTC 
I am not sure, if this is a bug in FlaggedRevs or Scribunto, but there are not playing good together.

Going to a stable version of a module gives you a page without Geshi highlighting and with script errors.

Compare these pages:
https://de.wikipedia.org/wiki/Modul:DemoArgs?stable=1
https://de.wikipedia.org/wiki/Modul:DemoArgs?stable=0
Comment 1 Brad Jorsch 2013-05-20 16:00:17 UTC 
It appears to be a bug in FlaggedRevs, in that it just assumes page text is wikitext when displaying the stable version rather than using ContentHandler to determine how the page is to be displayed.

Adjusting bug title accordingly.
Comment 2 Umherirrender 2013-05-20 16:22:07 UTC 
stable=1 is only a way to say FlaggedRevs it should show the stable version across user settings (on de.wp anonym user always get stable version, loggedin user get per default the unstable version, but can change it in preferences to the stable, so it is easier to link with stable= in the url instead of saying, some one have to log in to see the difference)
Comment 3 Gerrit Notification Bot 2013-06-04 03:24:28 UTC 
Related URL: https://gerrit.wikimedia.org/r/66893 (Gerrit Change I1cb3a83426cfa9db962e6e8cef06cc32b8713501)
Comment 4 Umherirrender 2013-06-13 18:28:49 UTC 
Is now live on de.wp and it looks good (pages needs a purge, but that is okay)

Thanks.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links