Last modified: 2014-02-12 23:52:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50730, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48730 - Formatter: Sections on Commons are not collapsed
Formatter: Sections on Commons are not collapsed
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-22 20:59 UTC by Jon
Modified: 2014-02-12 23:52 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2013-05-22 20:59:17 UTC
https://commons.m.wikimedia.org/w/index.php?title=File:Kaselaug_-_Rabivere_maastikukaitseala.jpg&mobileaction=toggle_view_mobile

File history,File usage on Commons,File usage on other wikis, Metadata are not collapsible.
Comment 1 Max Semenik 2013-08-01 19:32:43 UTC
That's because they're just <h2> as opposed to <h2><span id="mw-headline"> - we're converting only the span, never touching the h2's themselves. What do you propose to do with them Jon?
Comment 2 Jon 2013-08-03 03:25:59 UTC
Any reason these don't contain spans?
Sounds like something to change in core to be consistent with other headings.
Comment 3 Max Semenik 2013-08-09 06:07:52 UTC
Because they're not result of wikitext parse.
Comment 4 Jon 2013-08-14 22:16:31 UTC
Any reason we can't split on h2 with optional span?
Comment 5 Max Semenik 2013-08-15 16:12:12 UTC
Hmm, I can *theorize* that this behaviour is due to us originally screen-scraping everything, including headings from chrome.
Comment 6 Jon 2013-08-27 18:39:07 UTC
One thing we could do is transform all the HTML on the client and drop headingTransform altogether... this scares me but in theory it should be possible...
Comment 7 Jon 2013-08-27 19:31:43 UTC
We /could/ do this in JavaScript. This would involve collecting known headings and constructing the sections manually to collapse them.
Comment 8 Jon 2013-09-11 23:38:29 UTC
https://gerrit.wikimedia.org/r/#/c/83837/ fixes this.
Comment 9 Jon 2013-09-23 19:09:32 UTC
This should now be resolved. yey!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links