Last modified: 2014-02-01 14:05:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50813, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48813 - User blocked from editing talk page still can edit IP talk page with his autoblocked IP
User blocked from editing talk page still can edit IP talk page with his auto...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Tyler Romeo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-25 15:55 UTC by Teles
Modified: 2014-02-01 14:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Teles 2013-05-25 15:55:12 UTC
I just saw a situation on pt.wiki on which an user is blocked from editing (sending mail and talk page editing disabled). Though account couldn't edit talk page, he still could edit his IP talk page as it appear that autoblock didn't stop it.

I wish that autoblock could also disable talk page editing when unlogged. Maybe it is an important information: user was firstly blocked with permission to edit talk page. Permission to edit talk page was removed right afterwards and before the IP could edit its talk page. Maybe the first autoblock messed up?

--Teles
Comment 1 Tyler Romeo 2013-05-31 00:48:30 UTC
(In reply to comment #0)
> I just saw a situation on pt.wiki on which an user is blocked from editing
> (sending mail and talk page editing disabled). Though account couldn't edit
> talk page, he still could edit his IP talk page as it appear that autoblock
> didn't stop it.

I know this seems obvious, but I have to ask just in case: was the block an auto-block (i.e., was the "Prevent editing from IP address" checkbox checked)?
Comment 2 Jasper Deng 2013-05-31 00:49:38 UTC
I don't think this is necessarily a thing to change, because an IP may be mistakenly caught in an autoblock and would have to appeal the bug.
Comment 3 Jasper Deng 2013-05-31 00:49:55 UTC
I meant "block", not "bug", sorry.
Comment 4 Teles 2013-05-31 01:37:00 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > I just saw a situation on pt.wiki on which an user is blocked from editing
> > (sending mail and talk page editing disabled). Though account couldn't edit
> > talk page, he still could edit his IP talk page as it appear that autoblock
> > didn't stop it.
> 
> I know this seems obvious, but I have to ask just in case: was the block an
> auto-block (i.e., was the "Prevent editing from IP address" checkbox
> checked)?

Yes.
Comment 5 Teles 2013-05-31 01:44:19 UTC
(In reply to comment #2)
> I don't think this is necessarily a thing to change, because an IP may be
> mistakenly caught in an autoblock and would have to appeal the bug.

That means that every vandal account that is blocked will be able to edit his talk page (as most blocks allow that). Then the sysop will prevent him from editing his talk page. Then he will unlog and edit his IP talk page. Then the sysop will have to block the IP. Isn't that too much? An autoblock takes only a day to end; the possible damage to autoblock is not that much.
Comment 6 db [inactive,noenotif] 2013-06-01 21:01:58 UTC
The created autoblock gets no update on reblock, and so the changed param (talk page edit disabled) is not changed there.

Since some month each auto blocks knows it parent, so on reblock it should be possible to select all auto blocks for the current block and set the changed flags and save it.
Comment 7 Tyler Romeo 2013-06-02 01:05:34 UTC
(In reply to comment #6)
> The created autoblock gets no update on reblock, and so the changed param
> (talk
> page edit disabled) is not changed there.
> 
> Since some month each auto blocks knows it parent, so on reblock it should be
> possible to select all auto blocks for the current block and set the changed
> flags and save it.

Wait, so this bug is about a block whose parameters were changed? Because that wasn't specified in the original report.
Comment 8 Teles 2013-06-02 01:55:19 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > The created autoblock gets no update on reblock, and so the changed param
> > (talk
> > page edit disabled) is not changed there.
> > 
> > Since some month each auto blocks knows it parent, so on reblock it should be
> > possible to select all auto blocks for the current block and set the changed
> > flags and save it.
> 
> Wait, so this bug is about a block whose parameters were changed? Because
> that
> wasn't specified in the original report.

Yes. That is what I tried to say on second paragraph of first message; sorry if I couldn't.

Here is the block log: https://pt.wikipedia.org/w/index.php?title=Especial:Registo/block&page=Usu%C3%A1rio%3AMan%C3%ADaco+da+Cruz

--Teles
https://pt.wikipedia.org/wiki/Usu%C3%A1rio:Teles
Comment 9 Tyler Romeo 2013-06-02 02:00:13 UTC
OK, I now understand and can confirm the bug. This occurs because on Special:Block when you update a block, it just deletes the old block and inserts a new one. May take a while to fix this one.
Comment 10 Hazard-SJ 2013-06-02 02:07:13 UTC
Was the autoblock logged as before or after the block modification?
Comment 11 Teles 2013-06-02 02:27:53 UTC
(In reply to comment #10)
> Was the autoblock logged as before or after the block modification?

15:03, 25 May 2013 (UTC) - First account block with permission to edit talk page.
15:04, 25 May 2013 (UTC) - Second account block without permission to edit talk page.
15:28, 25 May 2013 (UTC) - Unlogged edit on IP talk page.

So, account blocks occured before the unlogged edit.

--Teles
https://pt.wikipedia.org/wiki/Usu%C3%A1rio:Teles
Comment 12 Teles 2013-06-02 02:32:47 UTC
(In reply to comment #9)
> OK, I now understand and can confirm the bug. This occurs because on
> Special:Block when you update a block, it just deletes the old block and
> inserts a new one. May take a while to fix this one.

Tyler, is it safe to say that if the first account block was set to disable talk page editing, the IP couldn't edit talk page when unlogged?

--Teles
Comment 13 Hazard-SJ 2013-06-02 02:43:38 UTC
(In reply to comment #2)
> I don't think this is necessarily a thing to change, because an IP may be
> mistakenly caught in an autoblock and would have to appeal the bug.

Jasper Deng, the MediaWiki default is to disallow talk page editing when blocked, so if anything, it should be disabled by default for autoblocks, and not enabled.
Comment 14 Hazard-SJ 2013-06-02 02:43:56 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > Was the autoblock logged as before or after the block modification?
> 
> 15:03, 25 May 2013 (UTC) - First account block with permission to edit talk
> page.
> 15:04, 25 May 2013 (UTC) - Second account block without permission to edit
> talk
> page.
> 15:28, 25 May 2013 (UTC) - Unlogged edit on IP talk page.
> 
> So, account blocks occured before the unlogged edit.
> 
> --Teles
> https://pt.wikipedia.org/wiki/Usu%C3%A1rio:Teles

Teles, so was the autoblock logged at 15:28, 25 May 2013 (UTC) as well?
Comment 15 Teles 2013-06-02 02:45:45 UTC
Sorry... I don't know what do you mean by "autoblock logged".

--Teles
Comment 16 Hazard-SJ 2013-06-02 04:46:04 UTC
(In reply to comment #15)
> Sorry... I don't know what do you mean by "autoblock logged".
> 
> --Teles

Don't autoblocks show up on the block list?
Comment 17 Teles 2013-06-02 04:52:46 UTC
(In reply to comment #16)
> (In reply to comment #15)
> > Sorry... I don't know what do you mean by "autoblock logged".
> > 
> > --Teles
> 
> Don't autoblocks show up on the block list?

I think they do; until they expire. I didn't check the log though. 


(In reply to comment #14)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > Was the autoblock logged as before or after the block modification?
> > 
> > 15:03, 25 May 2013 (UTC) - First account block with permission to edit talk
> > page.
> > 15:04, 25 May 2013 (UTC) - Second account block without permission to edit
> > talk
> > page.
> > 15:28, 25 May 2013 (UTC) - Unlogged edit on IP talk page.
> > 
> > So, account blocks occured before the unlogged edit.
> > 
> > --Teles
> > https://pt.wikipedia.org/wiki/Usu%C3%A1rio:Teles
> 
> Teles, so was the autoblock logged at 15:28, 25 May 2013 (UTC) as well?

An IP edit was done at 15:28; not the autoblock log.

--Teles
Comment 18 Hazard-SJ 2013-06-02 05:10:48 UTC
OK
Comment 19 Tyler Romeo 2013-06-02 16:11:42 UTC
(In reply to comment #12)
> (In reply to comment #9)
> > OK, I now understand and can confirm the bug. This occurs because on
> > Special:Block when you update a block, it just deletes the old block and
> > inserts a new one. May take a while to fix this one.
> 
> Tyler, is it safe to say that if the first account block was set to disable
> talk page editing, the IP couldn't edit talk page when unlogged?
> 
> --Teles

Yes. When an autoblock is generated, it inherits many of the properties of the original block, including talk page editing. But when the block is editing, the original block is deleted and re-created, and the autoblocks are never updated.
Comment 20 Gerrit Notification Bot 2013-06-02 17:37:55 UTC
Related URL: https://gerrit.wikimedia.org/r/66366 (Gerrit Change I5403f6e1d7f8f07273cd5da8068b928fdddcdfc9)
Comment 21 Teles 2013-11-06 22:48:53 UTC
You just need to be careful to not reduce an IP block due to an autoblock update. I mean, in case you block an IP for, say, a month, it should not be autoblocked for a day when we indef an account that was using this IP.
Comment 22 Gerrit Notification Bot 2014-01-31 18:59:12 UTC
Change 66366 merged by jenkins-bot:
Make autoblocks update with the parent block

https://gerrit.wikimedia.org/r/66366
Comment 23 Umherirrender 2014-02-01 14:05:31 UTC
was successfully merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links