Last modified: 2013-09-02 20:57:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50815, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48815 - The [close] link shouldn't be injected into HTML
The [close] link shouldn't be injected into HTML
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
DismissableSiteNotice (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: accessibility
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-25 16:16 UTC by Liangent
Modified: 2013-09-02 20:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2013-05-25 16:16:58 UTC 
Otherwise users without CSS and JS (= text browsers, screen readers etc) see it.

Inserting it with JS might be a solution. This may have pages jerking, but CentralAuth causes a bigger one.

Anyway a small link won't affect page layout much if there's already something in the notice. This means, we need to check whether there's really a notice ( .text() != '' ) before creating the link.
Comment 1 Kevin Israel (PleaseStand) 2013-09-02 20:54:11 UTC 
I think the way to go might be to change the text link to a
fixed-size close icon, as suggested (under "Constrained formatting") on
https://www.mediawiki.org/wiki/Requests_for_comment/Dismissable_notices .
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links