Last modified: 2013-10-30 10:59:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50832, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48832 - Browser language detection does not work at en.wikipedia.beta.wmflabs.org
Browser language detection does not work at en.wikipedia.beta.wmflabs.org
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: browser-test-bug
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-26 10:08 UTC by Željko Filipin
Modified: 2013-10-30 10:59 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Browser language detection does not work at en.wikipedia.beta.wmflabs.org (489.73 KB, image/png)
2013-05-26 10:08 UTC, Željko Filipin
Details

Description Željko Filipin 2013-05-26 10:08:49 UTC
Created attachment 12398 [details]
Browser language detection does not work at en.wikipedia.beta.wmflabs.org

To reproduce:

- set browser default language to German
- go to a random page
- navigation should be in German

This works just fine at sandbox.translatewiki.net, but not at en.wikipedia.beta.wmflabs.org.

We have a failed test:

https://github.com/wikimedia/qa-browsertests/blob/master/features/uls_accept_language.feature

Take a look at attached screen shot.
Comment 1 Antoine "hashar" Musso (WMF) 2013-08-01 08:54:53 UTC
I dont think that feature is enabled on the production wiki. https://commons.wikimedia.org/ shows me an English interface when my browser has French as default.

Redirecting bug to ULS to find out whether this is wanted on the prod wikis.
Comment 2 Niklas Laxström 2013-08-01 09:03:45 UTC
Yes we would like it very much! But $wgULSLanguageDetection is set to false on WMF wikis until Varnish can be configured to process Accept-Language without breaking caching.

There is an easier step before that and that is to set $wgULSAnonCanChangeLanguage to true and have Varnish to vary by the language cookie -- also waiting for a support in Varnish.
Comment 3 Siebrand Mazeland 2013-08-01 11:39:49 UTC
I don't really know what to do with this report. We know this doesn't work, we also know that our infrastructure isn't ready for this, at least when it comes to anonymous users; Ops tells us that Varnish 4 is needed to maybe allow us to make this work for anonymous users. We could make it work for logged in users, along the lines of

Given
  a MediaWiki instance
When
  I haven't logged into it before (i.e. new account creation), or
  I have never set a user interface language ("backward compat handling)
Then
 My user interface language will be set according to a supported language in MediaWiki based on my browser's Accept-Language value.

I'm setting this to "enhancement/lowest" for now, despite the currently incorrect issue summary.
Comment 4 Željko Filipin 2013-08-08 11:09:04 UTC
As far as I am concerned, if we do not have an environment where we can test this feature, I vote for closing the bug and deleting the test.

We can also change the test to the one Siebrand suggested in comment #3, if that is something that we want tested every day.
Comment 5 Siebrand Mazeland 2013-08-14 14:17:13 UTC
The tests are fine, we just don't have a proper test environment for it. If I provide one, even if it's outside of the Wikimedia realm, would that be enough to retain the tests?
Comment 6 Željko Filipin 2013-08-21 19:12:37 UTC
As far as I am concerned, if the tests provide value, and if we have an environment where we can run them, then we should keep them. :)
Comment 7 Niklas Laxström 2013-10-30 10:59:42 UTC
Running on sandbox now. I consider that as being a fix for this bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links