Last modified: 2014-10-06 16:58:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50858, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48858 - jQuery's .ui-helper-clearfix class is broken/outdated
jQuery's .ui-helper-clearfix class is broken/outdated
Status: RESOLVED DUPLICATE of bug 71601
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.22.0
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
https://de.wikipedia.org/wiki/Vorlage...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-27 12:26 UTC by entlinkt
Modified: 2014-10-06 16:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description entlinkt 2013-05-27 12:26:09 UTC
http://bugs.jqueryui.com/ticket/8442 is currently affecting the template [[de:Vorlage:Gesprochene_Version?useskin=monobook#Vorlage_Gesprochene_Version]].

This can be fixed by updating jquery.ui.core.css to the most recent version from jQuery UI (for all skins, please).
Comment 1 entlinkt 2013-05-27 12:28:35 UTC
The link in the post above is broken, added a working one in the "URL" field.
Comment 2 Andre Klapper 2013-05-27 16:10:02 UTC
Thanks for reporting. Confirming.
Comment 3 Marius Hoch 2013-06-29 23:40:23 UTC
Workaround on dewiki: https://de.wikipedia.org/w/index.php?curid=1115645&diff=120054505&oldid=119746420
Comment 4 Greg Grossmeier 2013-07-01 16:12:10 UTC
Is there another test page we can use that doesn't have the workaround? Would be great to reproduce this and test against :) Thanks!
Comment 5 entlinkt 2013-07-02 20:46:54 UTC
It should be possible to disable that CSS rule in tools like Firebug/Dragonfly/Developer tools etc. or via .ui-helper-clearfix:before, .ui-helper-clearfix:after { border-collapse: separate; } in a user-specific CSS file.

What happens is the following: The template [[de:Vorlage:Gesprochene Version]] contains a table with the attribute "cellspacing=8" (transcluded via [[de:Vorlage:Bausteindesign3}]). This sets the CSS property "border-spacing: 8px", which is an inherited property.

Inside the table, there is the media player control, which uses the CSS class "ui-helper-clearfix". That CSS class in turn is creating a pseudo-element via the rule

.ui-helper-clearfix:before,
.ui-helper-clearfix:after {
        content: "";
        display: table;
}

in resources/jquery.ui/themes/default/jquery.ui.core.css. This pseudo-element in turn inherits the "border-spacing: 8px" from the outer table.

My edit to [[de:MediaWiki:Common.css]] is not actually a workaround, it's the proper fix that has also been applied to JQuery upstream - cf. https://github.com/jquery/jquery-ui/commit/cb42ee7ccdf6e32be14341a34a037c7f4508c157#themes/base/jquery.ui.core.css
Comment 6 entlinkt 2014-10-06 16:58:28 UTC

*** This bug has been marked as a duplicate of bug 71601 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links