Last modified: 2013-05-29 06:18:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50881, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48881 - WebInstallerOutput.getCssUrl add duplicate '?' when appending parameters to url
WebInstallerOutput.getCssUrl add duplicate '?' when appending parameters to url
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.21.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-28 07:31 UTC by Johan Euphrosine
Modified: 2013-05-29 06:18 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Johan Euphrosine 2013-05-28 07:31:27 UTC 
Html::linkedStyle( $_SERVER['PHP_SELF'] . '?css=' . $this->getDir() );

Will returns the following url:
/mw-config/index.php?page=Welcome?css=ltr

Causing bad arguments parsing on certain web servers.

Instead getCssUrl should rely on something like http://php.net/manual/en/function.http-build-query.php to build the query string properly.
Comment 1 Johan Euphrosine 2013-05-29 06:18:34 UTC 
Closing this bug, as  $_SERVER['PHP_SELF'] should not include query string parameters: 
http://php.net/manual/en/reserved.variables.server.php
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links