Last modified: 2013-10-09 17:23:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50888, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48888 - Improve data value validation and error handling in api
Improve data value validation and error handling in api
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on: 38675 49186 49264
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-28 10:59 UTC by Aude
Modified: 2013-10-09 17:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2013-05-28 10:59:58 UTC 
In the SetQualifier module, I gave it invalid data value input (and it was being handled incorrectly in the api).  I got back an exception with full stack trace in the api result.  

Generally speaking, in a number of places, the api is also doing insufficient validation and error handling of the data values.  The api user should *not* see an exception in the api error output.  Any exceptions due to invalid value input should be caught and translated into a proper api error message and code.

(See also related bug 48864 and bug 48473)
Comment 1 Daniel Kinzler 2013-07-01 12:26:47 UTC 
Making this as depending on 49264. Input validation has improved since this was filed, but it's still possible to trigger a fatal error by submitting a structurally invalid data value.
Comment 2 Lydia Pintscher 2013-10-08 21:53:25 UTC 
Closing as this is too general to be useful and we have other bugs for it.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links