Last modified: 2014-09-23 00:14:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50918, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48918 - Placeholders appear as password characters in IE6-9
Placeholders appear as password characters in IE6-9
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-28 23:29 UTC by Steven Walling
Modified: 2014-09-23 00:14 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
IE8 (34.39 KB, image/png)
2013-05-28 23:29 UTC, Steven Walling
Details
New create account screen in IE9 (80.51 KB, image/png)
2013-05-29 00:20 UTC, Matthew Flaschen
Details
IE9 log in (62.30 KB, image/png)
2013-05-29 00:20 UTC, Matthew Flaschen
Details

Description Steven Walling 2013-05-28 23:29:47 UTC
Created attachment 12411 [details]
IE8

See attachment from IE8. In all versions up of IE up to 8 the placeholders appear as strange bars.
Comment 1 Matthew Flaschen 2013-05-29 00:19:35 UTC
Only the password.  The username looks fine, except that the color didn't take.

'placeholder' is an HTML 5 feature, but for unsupported browsers (see http://caniuse.com/#search=placeholder), we use a special module jquery.placeholder.  I've moved this to the JavaScript module accordingly.  jquery.placeholder works by putting the placeholder in the value.  Then, JavaScript erases it when you click into the field.

This breaks down for password fields, since you can't see the actual text.

I'll add screenshots for IE9.  It doesn't work there either; it should in IE10, since that has native placeholder.
Comment 2 Matthew Flaschen 2013-05-29 00:20:11 UTC
Created attachment 12412 [details]
New create account screen in IE9
Comment 3 Matthew Flaschen 2013-05-29 00:20:36 UTC
Created attachment 12413 [details]
IE9 log in
Comment 4 Steven Walling 2013-05-29 00:27:49 UTC
(In reply to comment #1)
> Only the password.  The username looks fine, except that the color didn't
> take.
> 
> 'placeholder' is an HTML 5 feature, but for unsupported browsers (see
> http://caniuse.com/#search=placeholder), we use a special module
> jquery.placeholder.  I've moved this to the JavaScript module accordingly. 
> jquery.placeholder works by putting the placeholder in the value.  Then,
> JavaScript erases it when you click into the field.
> 
> This breaks down for password fields, since you can't see the actual text.
> 
> I'll add screenshots for IE9.  It doesn't work there either; it should in
> IE10,
> since that has native placeholder.

Yeah the blanking when clicking in the field doesn't work quite right in IE9, but at least the placeholder text is the right shape, so users know what it is.
Comment 5 Matthew Flaschen 2013-05-29 00:49:24 UTC
Steven checked further, and the clicking does work.

I found some suggestions on how to deal with the bar/dot problem.  I'll submit a Gerrit when I get it to work.
Comment 6 Matthew Flaschen 2013-05-29 04:39:23 UTC
I have a draft fix at https://gerrit.wikimedia.org/r/#/c/65871/

It doesn't completely work for IE6 or IE7 since there's some kind of JS error.  Unfortunately, IE8 is the first one with a tolerable script debugger, and the error doesn't appear IE8+.

So another set of eyes would be helpful.
Comment 7 Matthew Flaschen 2014-09-22 23:49:47 UTC
(In reply to Matthew Flaschen from comment #6)
> It doesn't completely work for IE6 or IE7 since there's some kind of JS
> error.  Unfortunately, IE8 is the first one with a tolerable script
> debugger, and the error doesn't appear IE8+.

We're no longer serving JavaScript to IE 6 and IE 7, so we should retest this. (Also, I believe IE 6 and IE 7 will no longer show any placeholder, broken or otherwise.  We're no longer serving JavaScript to them, so the shim won't load.)
Comment 8 Steven Walling 2014-09-23 00:14:21 UTC
Tested in Sauce for IE 6-9. No longer an issue, though there other problems natch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links