Last modified: 2013-06-14 07:17:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50952, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 48952 - Show debug output in toolbar


Summary:	Show debug output in toolbar

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	physikerwelt

URL:
Whiteboard:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-05-29 20:57 UTC by physikerwelt
Modified:	2013-06-14 07:17 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
show debug output in toolbar (460 bytes, patch) 2013-05-29 20:57 UTC, physikerwelt	Details
Add an attachment (proposed patch, testcase, etc.)

Description physikerwelt 2013-05-29 20:57:22 UTC

Created attachment 12422 [details]
show debug output in toolbar

I'd prefer if the debug output written with the function wfDebugLog would be printed to the debug toolbar. Actually only the wfDebug function is written to the debug toolbar output.
If someone has the same feeling use the attached patch.

Comment 1 Alex Monk 2013-05-29 23:30:41 UTC

Comment on attachment 12422 [details]
show debug output in toolbar

+patch

Comment 2 Matthew Flaschen 2013-05-29 23:37:53 UTC

We should make sure this doesn't cause security issues (if private info uses this log path).

Comment 3 Matthew Flaschen 2013-05-29 23:42:24 UTC

Never mind, Krenair noted that wgDebugToolbar already must be false in production.

Comment 4 Umherirrender 2013-05-31 20:10:07 UTC

Component Logging is about Special:Log, not debug logging. Changed to general
for the moment, no idea for a better component

Comment 5 Andre Klapper 2013-06-03 08:41:53 UTC

Hi! Thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly.
Thanks again! We appreciate your contribution.

Comment 6 Pavel Selitskas [wizardist] 2013-06-06 13:30:54 UTC

Patch submitted to Gerrit: Ib979df08

Comment 7 Gerrit Notification Bot 2013-06-14 03:14:40 UTC

https://gerrit.wikimedia.org/r/66394 (Gerrit Change Ib979df080332e16c8e0e6a89eab8741986ab39c3) | change APPROVED and MERGED [by jenkins-bot]

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links