Last modified: 2014-09-15 16:05:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50953, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48953 - API siteinfo skins should use English skin names in * instead of the value in $wgValidSkinNames
API siteinfo skins should use English skin names in * instead of the value in...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.22.0
All All
: Low enhancement (vote)
: 1.24.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-29 22:26 UTC by Daniel Friesen
Modified: 2014-09-15 16:05 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Friesen 2013-05-29 22:26:23 UTC
Currently the siteinfo API's skins output uses the value of the relevant $wgValidSkinNames entry. However this is not really a skin name at all. It's a key used to determine the class name of the class that implements the skin.

* Right now that means names like "CologneBlue" instead of "Cologne Blue".
* If someone implements a skin system that uses a single class and simple templates for each skin that means you'll start seeing completely useless names like "FooSkinSystem" for "This is my skin", "That is his skin", and "She made this skin" names.
* If one of my other changes gets merged you may also start seeing things like "{ThisIsMyClassName}".

We should start outputting the English i18n for the skin instead of this.
Comment 1 Gerrit Notification Bot 2014-08-29 19:59:23 UTC
Change 157275 had a related patch set uploaded by Bartosz Dziewoński:
ApiQuerySiteinfo: Use proper localised skin display names if available

https://gerrit.wikimedia.org/r/157275
Comment 2 Gerrit Notification Bot 2014-09-15 15:59:57 UTC
Change 157275 merged by jenkins-bot:
ApiQuerySiteinfo: Use proper localised skin display names if available

https://gerrit.wikimedia.org/r/157275

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links