Last modified: 2013-06-29 13:02:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50979, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48979 - E-mail addresses are getting double-escaped
E-mail addresses are getting double-escaped
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-30 15:33 UTC by James Forrester
Modified: 2013-06-29 13:02 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-05-30 15:33:27 UTC
In both the "Add Reviewer" box and the search box with "owner:..." - you now get "Taha<wikitaha@gmail.com>" which is a bit ugly. Some upstream change?
Comment 1 christian 2013-05-30 16:10:09 UTC
For the "Add Reviewer" box, I can reproduce the problem only for the letter
"T" (without quotes, regardless of case). If I go on typing for example "Ta",
the problem disappears. Other single letter values work without problems in
the "Add Reviewer" box.

Same for the search box. "owner:T" allows to exhibit the problem, while
"owner:Ta" does not. Neither do other single letter owners, as "owner:Q".

The problem also occurs for the other search predicates as for example reviewer.
Comment 2 Chad H. 2013-05-31 21:15:44 UTC
Wasn't this fixed upstream? Or reported? I could've sworn we've had this discussion before.
Comment 3 christian 2013-05-31 22:30:05 UTC
David recalled that it was reported upstream half a year ago
  https://code.google.com/p/gerrit/issues/detail?id=1574
, but the fix is rather fresh :-) still waiting for review
  https://gerrit-review.googlesource.com/#/c/46370/
. I'll push it to our branch once I got some feedback on it.
Comment 4 christian 2013-06-03 09:03:02 UTC
Fix got accepted upstream, submitting for our local branch
Comment 5 Gerrit Notification Bot 2013-06-03 09:03:20 UTC
Related URL: https://gerrit.wikimedia.org/r/66387 (Gerrit Change Ifc0b4f4d52a2b2a5a6a511b943a11d752c186c39)
Comment 6 christian 2013-06-29 13:02:03 UTC
Should be fixed since we upgraded gerrit on 2013-06-27.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links