Last modified: 2014-06-23 19:17:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51000, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 49000 - VisualEditor: Incorrect tab text (create vs. edit) shown on Special:MovePage, Special:Undelete, others?


Summary:	VisualEditor: Incorrect tab text (create vs. edit) shown on Special:MovePage,...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor
Target Milestone:	VE-deploy-2013-09-12
Assigned To:	James Forrester

URL:
Whiteboard:
Keywords:	easy, javascript

Depends on:	53774
Blocks:
	Show dependency tree / graph

Reported:	2013-05-31 00:01 UTC by Hazard-SJ
Modified:	2014-06-23 19:17 UTC (History)
CC List:	8 users (show)

See Also:	66885
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Hazard-SJ 2013-05-31 00:01:37 UTC

When attempting to move a page where VisualEditor is enabled (take https://www.mediawiki.org/wiki/Special:MovePage/VisualEditor:Sandbox for an example), the tab "Create source" should be an "Edit source" tab instead.

Comment 1 Andre Klapper 2013-06-05 14:15:41 UTC

--> VisualEditor

Comment 2 Krinkle 2013-07-22 17:51:49 UTC

Confirmed. It says "Read | Edit | Create source | View history".

https://www.mediawiki.org/wiki/Special:MovePage/Sandbox

Comment 3 John Mark Vandenberg 2013-07-26 02:15:03 UTC

Also shown on Special:Undelete, after the page has been restored.

i.e. "User:John Vandenberg/test has been restored" has tabs: Read | Edit | Create source | View history

Comment 4 Francisco 2013-07-27 18:10:29 UTC

Also show on Special:Whatlinkshere (e.g. https://it.wikipedia.org/wiki/Speciale:PuntanoQui/Wikipedia )

Comment 5 Ed Sanders 2013-08-01 21:59:38 UTC

More importantly, it lets you load VE dynamically, which it shouldn't.

Comment 6 Gerrit Notification Bot 2013-08-01 22:20:39 UTC

Change 77246 had a related patch set uploaded by Esanders:
Fix edit links on special pages

https://gerrit.wikimedia.org/r/77246

Comment 7 Gerrit Notification Bot 2013-08-01 22:22:24 UTC

Change 77246 merged by jenkins-bot:
Fix edit links on special pages

https://gerrit.wikimedia.org/r/77246

Comment 8 Gerrit Notification Bot 2013-08-01 22:52:33 UTC

Change 77253 had a related patch set uploaded by Esanders:
Fix pageExists/isViewPage behaviour

https://gerrit.wikimedia.org/r/77253

Comment 9 Gerrit Notification Bot 2013-08-01 23:59:54 UTC

Change 77253 merged by jenkins-bot:
mw.ViewPageTarget.init: Fix pageExists/isViewPage behaviour

https://gerrit.wikimedia.org/r/77253

Comment 10 Gerrit Notification Bot 2013-08-02 03:31:08 UTC

Change 77165 had a related patch set uploaded by Catrope:
Move edit tab generation into PHP and make it more configurable

https://gerrit.wikimedia.org/r/77165

Comment 11 James Forrester 2013-08-02 05:57:56 UTC

Now fixed and deployed.

Comment 12 Elitre 2013-08-13 12:47:21 UTC

I think I can still see this? http://en.wikipedia.org/wiki/Special:WhatLinksHere/Esempio 
Thanks.

Comment 13 Elitre 2013-08-13 12:49:49 UTC

I mean, as the page does not exist, shouldn't that read Create source instead, as in http://en.wikipedia.org/wiki/Esempio ?

Comment 14 James Forrester 2013-09-04 20:04:25 UTC

(In reply to comment #12)
> I think I can still see this?
> http://en.wikipedia.org/wiki/Special:WhatLinksHere/Esempio 
> Thanks.

This is caused by (core) bug 53774 which we will need to fix.

Comment 15 Gerrit Notification Bot 2013-09-04 20:08:08 UTC

Change 82744 had a related patch set uploaded by Jforrester:
Reference core bug 53774 in bug 49000 comment

https://gerrit.wikimedia.org/r/82744

Comment 16 Gerrit Notification Bot 2013-09-05 04:55:50 UTC

Change 82744 merged by jenkins-bot:
Reference core bug 53774 in bug 49000 comment

https://gerrit.wikimedia.org/r/82744

Comment 17 Alex Monk 2014-01-29 00:56:40 UTC

Is there anything left to do here?

Comment 18 James Forrester 2014-02-26 02:14:22 UTC

(In reply to Alex Monk from comment #17)
> Is there anything left to do here?

This appears fixed for now (albeit as a hack).

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links