Last modified: 2014-10-17 20:40:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51017, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49017 - Empty string displayed instead of Full Name/username in email notifications when no User: page exists
Empty string displayed instead of Full Name/username in email notifications w...
Status: UNCONFIRMED
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
1.21.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Vishnu Nk
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-31 16:22 UTC by Robinson Tryon
Modified: 2014-10-17 20:40 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robinson Tryon 2013-05-31 16:22:28 UTC
Tested on: MediaWiki 1.21.1

Email notifications regarding changes made by a user with no User: page display a blank instead of user's Full Name (or username).

For example:

---
Dear Admiral Ackbar,

The Foobar Wiki page CinnamonBun has been changed on 2013-05-31 by , see http://wiki.example.org/CinnamonBun for the current revision.
---

If the User: page exists, the Full Name appears:

---
Dear Admiral Ackbar,

The Foobar Wiki page CinnamonBun has been changed on 2013-05-31 by Princess Leia, see http://wiki.example.org/CinnamonBun for the current revision.
---

I haven't done rigorous testing here, so I'm not sure what happens if the User: page exists but the 'Full Name' is not set... probably good to check that case as well.

Danke.
Comment 1 Vishnu Nk 2013-12-22 03:49:24 UTC
Do you have any test case sir?
Comment 2 Robinson Tryon 2013-12-22 14:44:17 UTC
(In reply to comment #1)
> Do you have any test case sir?

I can write one up, I guess. Are you unable to repro the bug?

Off the top of my head:

1) install mediawiki
2) Create accounts 'foo' and 'bar' (with full names 'Foobie Fool' and 'Barbie Barn', respectively). Make sure they have associated email addresses so that they may get notifications. Do *not* create User:xxx pages for them.
3) Log-in as 'foo' and create page /Test (automagically watching that page)
4) Log-in as 'bar' and edit page /Test

Result:

User foo will receive a notification email as described in my previous comment, with what looks like incorrect/missing variable substitution (?).

Expected:

Complete sentences in the email notification :-)
Comment 3 Vishnu Nk 2013-12-22 17:30:27 UTC
Thankyou sir.
anyway im interested in this bug.Can you please assign it to me?
Comment 4 Robinson Tryon 2013-12-22 23:17:04 UTC
(In reply to comment #3)
> Thankyou sir.
> anyway im interested in this bug.Can you please assign it to me?

Hi Vishnu,

I don't have high enough privs in this Bugzilla installation to assign this bug to you, but perhaps Andrew Klapper (who did some triaging of the bug) can help you out with that :-)
Comment 5 Vishnu Nk 2014-01-02 16:56:21 UTC
Can anyone help me for getting more about the issue and how to fix this?
Comment 6 Andre Klapper 2014-01-02 20:37:52 UTC
Vishnu Nk: It's more likely if you ask clear and specific questions. 
Also see http://www.catb.org/~esr/faqs/smart-questions.html
Comment 7 Vishnu Nk 2014-01-03 12:51:25 UTC
Sir,Where I can find the file to change the code and fix this issue?
Comment 8 Andre Klapper 2014-01-03 13:24:17 UTC
You could use some strings from comment 0 that are not variable and search for them yourself in a local copy of the codebase, in order to find the place(s).
Comment 9 Vishnu Nk 2014-01-03 13:43:49 UTC
Thank you sir.will be working on it
Comment 10 Tony Thomas 2014-03-23 10:38:13 UTC
(In reply to Robinson Tryon from comment #2)
> 1) install mediawiki
> 2) Create accounts 'foo' and 'bar' (with full names 'Foobie Fool' and
> 'Barbie Barn', respectively). Make sure they have associated email addresses
> so that they may get notifications. Do *not* create User:xxx pages for them.
> 3) Log-in as 'foo' and create page /Test (automagically watching that page)
> 4) Log-in as 'bar' and edit page /Test
> 
> Result:
> 
> User foo will receive a notification email as described in my previous
> comment, with what looks like incorrect/missing variable substitution (?).

I cannot reproduce this bug. Looks like its fixed already. The email notif I got in the above scenario contained the Name perfectly. 
Note that I had given the Full name field completely for both the users.
Comment 11 Robinson Tryon 2014-03-23 15:09:05 UTC
(In reply to Tony Thomas from comment #10)
> 
> I cannot reproduce this bug. Looks like its fixed already. The email notif I
> got in the above scenario contained the Name perfectly. 
> Note that I had given the Full name field completely for both the users.

Hi Tony,

Against what version of MediaWiki are you testing?  I'm still seeing these results with the MediaWiki instance we're running for TDF/LibreOffice.

Danke.
Comment 12 Tony Thomas 2014-03-23 15:11:41 UTC
(In reply to Robinson Tryon from comment #11)
> Against what version of MediaWiki are you testing?  I'm still seeing these
> results with the MediaWiki instance we're running for TDF/LibreOffice.

I am on the development version (1.23 alpha). This was reported for 1.21.0. 
Do you get the same, even when Full Name was given during a/c creation ?
Comment 13 Robinson Tryon 2014-03-23 15:27:27 UTC
(In reply to Tony Thomas from comment #12)
> (In reply to Robinson Tryon from comment #11)
> > Against what version of MediaWiki are you testing?  I'm still seeing these
> > results with the MediaWiki instance we're running for TDF/LibreOffice.
> 
> I am on the development version (1.23 alpha). This was reported for 1.21.0. 
> Do you get the same, even when Full Name was given during a/c creation ?

We're currently using MW 1.21.6, and I've seen this issue repro recently. I'll try to find some time to test a dev version soon. Can you verify on current stable (1.22, I think?)
Comment 14 Tony Thomas 2014-03-23 16:26:57 UTC
(In reply to Robinson Tryon from comment #13)

> We're currently using MW 1.21.6, and I've seen this issue repro recently.
> I'll try to find some time to test a dev version soon. Can you verify on
> current stable (1.22, I think?)

Verified on Current stable release 1.22.4. I get this email 

Dear Foo,

The test page FOO has been changed on 23 March 2014 by Bar, see
http://localhost/mediawiki/index.php/FOO for the current revision.

See http://localhost/mediawiki/index.php?title=FOO&diff=next&oldid=2 to
view this change.

See http://localhost/mediawiki/index.php?title=FOO&diff=0&oldid=2 for
all changes since your last visit.

Editor's summary:  -

Contact the editor:
mail: http://localhost/mediawiki/index.php/Special:EmailUser/Bar
wiki: http://localhost/mediawiki/index.php/User:Bar

even though User:Bar is redlink
Comment 15 Mark Holmquist 2014-10-17 20:40:03 UTC
Given this hasn't seen any new activity of late, can we close as WFM or WONTFIX?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links