Last modified: 2014-10-24 19:59:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51033, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49033 - MobileFrontend: Inline code tags styled very large in articles
MobileFrontend: Inline code tags styled very large in articles
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Jon
design
:
: 53031 53347 72354 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-01 00:11 UTC by Jon
Modified: 2014-10-24 19:59 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Side-by-side comparison of proposed change (455.38 KB, image/png)
2013-08-26 15:34 UTC, Krinkle
Details

Description Jon 2013-06-01 00:11:46 UTC
See http://en.wikipedia.org/w/index.php?title=ggplot2&oldid=551167896
(Comparison with base graphics and other packages section)

The problem is vertical padding.
Comment 1 Jon 2013-06-07 21:29:47 UTC
https://gerrit.wikimedia.org/r/#/c/66287/ was a first stab.
Comment 2 Jon 2013-08-19 19:17:21 UTC
*** Bug 53031 has been marked as a duplicate of this bug. ***
Comment 3 Jon 2013-08-26 15:22:24 UTC
*** Bug 53347 has been marked as a duplicate of this bug. ***
Comment 4 Krinkle 2013-08-26 15:34:40 UTC
Created attachment 13169 [details]
Side-by-side comparison of proposed change

To fix: Move padding declaration out of "pre, code" ruleset. The approach "p > code" doesn't make sense since code is always inline and pre always block.

Then add:
pre { padding: 1em }
code { padding: 0.2em 0.5em; }

or something like that
Comment 5 Gerrit Notification Bot 2013-08-26 20:28:03 UTC
Change 81114 had a related patch set uploaded by Jdlrobson:
Bug 49033: Style pre and code tags properly

https://gerrit.wikimedia.org/r/81114
Comment 6 Gerrit Notification Bot 2013-08-26 21:24:48 UTC
Change 81114 had a related patch set uploaded by Krinkle:
Bug 49033: Style pre and code tags properly

https://gerrit.wikimedia.org/r/81114
Comment 7 Gerrit Notification Bot 2013-08-26 21:25:46 UTC
Change 81114 merged by jenkins-bot:
Style pre and code tags properly

https://gerrit.wikimedia.org/r/81114
Comment 8 Alex Monk 2014-08-08 17:41:35 UTC
Are you sure this got fixed fully? I'm still seeing <code> tags rendering weirdly - for example https://en.m.wikipedia.org/wiki/LibreSSL#Changes - which is even worse in the Android mobile app. (reported in https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7720246 )
Comment 9 Krinkle 2014-10-07 05:02:30 UTC
Yeah, same here.

https://meta.m.wikimedia.org/wiki/Tech/News/2014/41/en features a ridiculously large "phab" code tag.
Comment 10 Alex Monk 2014-10-22 11:46:26 UTC
*** Bug 72354 has been marked as a duplicate of this bug. ***
Comment 11 Gerrit Notification Bot 2014-10-24 16:09:33 UTC
Change 168606 had a related patch set uploaded by Florianschmidtwelzow:
Add handling of code tags in content

https://gerrit.wikimedia.org/r/168606
Comment 12 Gerrit Notification Bot 2014-10-24 18:05:53 UTC
Change 168606 merged by jenkins-bot:
Add handling of code tags in content

https://gerrit.wikimedia.org/r/168606

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links